esm: top-level Wasm without package type #57610

guybedford · 2025-03-25T00:03:13Z

We currently support node x.wasm through the ESM integration where .wasm files are located inside packages with "type": "module", but not without the module type on the package. This fixes the top-level execution case to always use the ESM loader.

This fix also adds a comprehensive test case for top-level Wasm execution that in turn can be extended to various end-to-end Wasm execution scenarios, in this example creating a JS object, setting some properties on it, and logging it back.

nodejs-github-bot · 2025-03-25T00:03:19Z

Review requested:

@nodejs/loaders

ljharb

wasm should definitely work regardless of the presence or value of the type setting 🚀

codecov · 2025-03-25T02:33:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (1c2d98d) to head (98d440a).
Report is 299 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57610      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185073   185074       +1     
  Branches    36222    36226       +4     
==========================================
+ Hits       166990   167017      +27     
+ Misses      11044    11031      -13     
+ Partials     7039     7026      -13

Files with missing lines	Coverage Δ
lib/internal/modules/run_main.js	`97.61% <100.00%> (+0.01%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GeoffreyBooth · 2025-03-25T04:06:09Z

Is there any documentation that needs updating?

github-actions · 2025-03-25T04:06:25Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @GeoffreyBooth.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

guybedford · 2025-03-25T06:12:18Z

According to the existing ESM_FILE_FORMAT spec, the package.json type shouldn't affect the .wasm Wasm interpretation, so I don't think we need to make any changes to the docs as this is what's already described.

test/fixtures/es-modules/top-level-wasm.wasm

mcollina

lgtm

richardlau · 2025-03-25T15:00:28Z

Is there any documentation that needs updating?

Maybe https://nodejs.org/docs/latest/api/cli.html#program-entry-point?

guybedford · 2025-03-25T19:37:00Z

Maybe https://nodejs.org/docs/latest/api/cli.html#program-entry-point?

Good point, I've updated that section to match the current implementation.

doc/api/cli.md

nodejs-github-bot · 2025-04-03T07:09:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65992/

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

guybedford · 2025-04-04T02:39:20Z

Landed in 870dec2.

PR-URL: nodejs#57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

Notable changes: deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 * (SEMVER-MINOR) graduate multiple experimental apis (James M Snell) #57765 esm: * (SEMVER-MINOR) graduate import.meta properties (James M Snell) #58011 * (SEMVER-MINOR) support top-level Wasm without package type (Guy Bedford) #57610 sqlite: * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490 src: * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) add ExecutionAsyncId getter for any Context (Attila Szegedi) #57820 stream: * (SEMVER-MINOR) preserve AsyncLocalStorage context in finished() (Gürgün Dayıoğlu) #57865 util: * (SEMVER-MINOR) add `types.isFloat16Array()` (Livia Medeiros) #57879 worker: * (SEMVER-MINOR) add worker.getHeapStatistics() (Matteo Collina) #57888 PR-URL: #58388

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

Notable changes: deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 * (SEMVER-MINOR) graduate multiple experimental apis (James M Snell) #57765 esm: * (SEMVER-MINOR) graduate import.meta properties (James M Snell) #58011 * (SEMVER-MINOR) support top-level Wasm without package type (Guy Bedford) #57610 sqlite: * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490 src: * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) add ExecutionAsyncId getter for any Context (Attila Szegedi) #57820 stream: * (SEMVER-MINOR) preserve AsyncLocalStorage context in finished() (Gürgün Dayıoğlu) #57865 util: * (SEMVER-MINOR) add `types.isFloat16Array()` (Livia Medeiros) #57879 worker: * (SEMVER-MINOR) add worker.getHeapStatistics() (Matteo Collina) #57888 PR-URL: TODO

Notable changes: deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 * (SEMVER-MINOR) graduate multiple experimental apis (James M Snell) #57765 esm: * (SEMVER-MINOR) graduate import.meta properties (James M Snell) #58011 * (SEMVER-MINOR) support top-level Wasm without package type (Guy Bedford) #57610 sqlite: * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490 src: * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) add ExecutionAsyncId getter for any Context (Attila Szegedi) #57820 stream: * (SEMVER-MINOR) preserve AsyncLocalStorage context in finished() (Gürgün Dayıoğlu) #57865 util: * (SEMVER-MINOR) add `types.isFloat16Array()` (Livia Medeiros) #57879 worker: * (SEMVER-MINOR) add worker.getHeapStatistics() (Matteo Collina) #57888 PR-URL: #58388

Notable changes: deps: * update timezone to 2025b (Node.js GitHub Bot) nodejs#57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) nodejs#58102 * (SEMVER-MINOR) graduate multiple experimental apis (James M Snell) nodejs#57765 esm: * (SEMVER-MINOR) graduate import.meta properties (James M Snell) nodejs#58011 * (SEMVER-MINOR) support top-level Wasm without package type (Guy Bedford) nodejs#57610 sqlite: * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) nodejs#57490 src: * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) nodejs#57171 * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) nodejs#57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) nodejs#57016 * (SEMVER-MINOR) add ExecutionAsyncId getter for any Context (Attila Szegedi) nodejs#57820 stream: * (SEMVER-MINOR) preserve AsyncLocalStorage context in finished() (Gürgün Dayıoğlu) nodejs#57865 util: * (SEMVER-MINOR) add `types.isFloat16Array()` (Livia Medeiros) nodejs#57879 worker: * (SEMVER-MINOR) add worker.getHeapStatistics() (Matteo Collina) nodejs#57888 PR-URL: nodejs#58388

Notable changes: deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 * (SEMVER-MINOR) graduate multiple experimental apis (James M Snell) #57765 esm: * (SEMVER-MINOR) graduate import.meta properties (James M Snell) #58011 * (SEMVER-MINOR) support top-level Wasm without package type (Guy Bedford) #57610 sqlite: * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490 src: * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) add ExecutionAsyncId getter for any Context (Attila Szegedi) #57820 stream: * (SEMVER-MINOR) preserve AsyncLocalStorage context in finished() (Gürgün Dayıoğlu) #57865 util: * (SEMVER-MINOR) add `types.isFloat16Array()` (Livia Medeiros) #57879 worker: * (SEMVER-MINOR) add worker.getHeapStatistics() (Matteo Collina) #57888 PR-URL: #58388

nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Mar 25, 2025

guybedford force-pushed the toplevel-wasm branch from f54b84d to 8631bf7 Compare March 25, 2025 00:03

ljharb approved these changes Mar 25, 2025

View reviewed changes

GeoffreyBooth approved these changes Mar 25, 2025

View reviewed changes

GeoffreyBooth added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 25, 2025

ljharb added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 25, 2025

ExE-Boss reviewed Mar 25, 2025

View reviewed changes

test/fixtures/es-modules/top-level-wasm.wasm Outdated Show resolved Hide resolved

mcollina approved these changes Mar 25, 2025

View reviewed changes

aduh95 approved these changes Mar 25, 2025

View reviewed changes

ljharb reviewed Mar 25, 2025

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

esm: support top-level Wasm without package type

98d440a

guybedford force-pushed the toplevel-wasm branch from 0cdb8f0 to 98d440a Compare April 2, 2025 03:56

This comment was marked as outdated.

Sign in to view

GeoffreyBooth approved these changes Apr 2, 2025

View reviewed changes

guybedford added a commit that referenced this pull request Apr 4, 2025

esm: support top-level Wasm without package type

870dec2

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

guybedford closed this Apr 4, 2025

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025

esm: support top-level Wasm without package type

91a58ad

PR-URL: nodejs#57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

esm: support top-level Wasm without package type

cbf9a64

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

esm: support top-level Wasm without package type

21f3c96

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

aduh95 added baking-for-lts PRs that need to wait before landing in a LTS release. and removed baking-for-lts PRs that need to wait before landing in a LTS release. labels May 6, 2025

aduh95 pushed a commit that referenced this pull request May 6, 2025

esm: support top-level Wasm without package type

c54bc00

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

esm: support top-level Wasm without package type

d72e510

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

aduh95 pushed a commit that referenced this pull request May 17, 2025

esm: support top-level Wasm without package type

cc7a259

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

aduh95 pushed a commit that referenced this pull request May 17, 2025

esm: support top-level Wasm without package type

295093b

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

esm: support top-level Wasm without package type

832640c

PR-URL: #57610 Reviewed-By: Jordan Harband Reviewed-By: Geoffrey Booth Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel

AuntyEms mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

esm: top-level Wasm without package type #57610

esm: top-level Wasm without package type #57610

Uh oh!

guybedford commented Mar 25, 2025

Uh oh!

nodejs-github-bot commented Mar 25, 2025

Uh oh!

ljharb left a comment

Uh oh!

codecov bot commented Mar 25, 2025 •

edited

Loading

Uh oh!

GeoffreyBooth commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

guybedford commented Mar 25, 2025

Uh oh!

Uh oh!

mcollina left a comment

Uh oh!

richardlau commented Mar 25, 2025

Uh oh!

guybedford commented Mar 25, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 3, 2025

Uh oh!

guybedford commented Apr 4, 2025

Uh oh!

Uh oh!

Uh oh!

esm: top-level Wasm without package type #57610

esm: top-level Wasm without package type #57610

Uh oh!

Conversation

guybedford commented Mar 25, 2025

Uh oh!

nodejs-github-bot commented Mar 25, 2025

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GeoffreyBooth commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

guybedford commented Mar 25, 2025

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

richardlau commented Mar 25, 2025

Uh oh!

guybedford commented Mar 25, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 3, 2025

Uh oh!

guybedford commented Apr 4, 2025

Uh oh!

Uh oh!

codecov bot commented Mar 25, 2025 •

edited

Loading