repl: deprecate repl.builtinModules

[dario-piotrowicz]

Fixes #57504

[juanarbol]

Amazing, thanks! If CI is happy, I'm happy as well.

[aduh95]

Can you please open a PR that first doc-deprecates the API? Hum actually, I'm not sure whether --pending-deprecation changes would be semver-major, so that might be fine EDIT2: just checked, we have precedents for landing as semver-patch pending deprecations

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65794/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (1123585) to head (e9fd52f).
Report is 61 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57508   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185055   185063    +8     
  Branches    36216    36221    +5     
=======================================
+ Hits       166975   166989   +14     
- Misses      11042    11043    +1     
+ Partials     7038     7031    -7     

Files with missing lines	Coverage Δ
lib/repl.js	94.91% <100.00%> (+0.02%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[BridgeAR]

I would actually like to keep this around and just fix the issue. The reason is that we expose underscored modules in Module one and those should never be used.

The current issue with the repl exposed one is that it filters node: prefixed ones out. That should not be the case.

We can also update the documentation to say "all besides underscored'.

[aduh95]

I would actually like to keep this around

Any particular reason for that? Do you have a use-case in mind?

[BridgeAR]

LGTM

I do overall agree that this should not exist on the repl, since we already have it exposed elsewhere.

I suggest to deprecate the runtime usage of the underscored modules as well in different PRs.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/57508
✔  Done loading data for nodejs/node/pull/57508
----------------------------------- PR info ------------------------------------
Title      repl: deprecate `repl.builtinModules` (#57508)
Author     Dario Piotrowicz  (@dario-piotrowicz)
Branch     dario-piotrowicz:dario/57504/deprecate-repl-builtinmodules -> nodejs:main
Labels     repl, author ready, needs-ci
Commits    1
 - repl: deprecate `repl.builtinModules`
Committers 1
 - Dario Piotrowicz 
PR-URL: https://github.com/nodejs/node/pull/57508
Reviewed-By: Juan José Arboleda 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
Reviewed-By: Xuguang Mei 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57508
Reviewed-By: Juan José Arboleda 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
Reviewed-By: Xuguang Mei 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 16 Mar 2025 22:36:51 GMT
   ✔  Approvals: 6
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/57508#pullrequestreview-2688852607
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2688878116
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2688878596
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/57508#pullrequestreview-2689145592
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2712875322
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57508#pullrequestreview-2696025170
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-03-17T00:31:48Z: https://ci.nodejs.org/job/node-test-pull-request/65794/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - repl: deprecate `repl.builtinModules`
- Querying data for job/node-test-pull-request/65794/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14261203802

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66019/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66023/

[nodejs-github-bot]

Landed in e232b4a