Skip to content

module: fix incorrect formatting in require(esm) cycle error message #57453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

module: fix incorrect formatting in require(esm) cycle error message #57453

merged 1 commit into from
Apr 9, 2025

Conversation

haykam821
Copy link
Contributor

This pull request includes minor wording and punctuation tweaks to fix the formatting of the require(esm) cycle error message. The message still seems a bit confusing to me, but these changes should at least be an improvement.

I am not sure whether tests should be implemented for this change, as the original error message didn't have tests either, but I can try my hand at implementing some if that would be preferred.

Fixes: #57451

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 14, 2025
BridgeAR
BridgeAR approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you mind adding a test for this as well? I didn't check, I guess we already have a spot where this is checked or at least triggered in tests and we can just test for the correct value to be there.

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (3329efe) to head (ce68ab6).
Report is 642 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57453   +/-   ##
=======================================
  Coverage   90.20%   90.21%           
=======================================
  Files         629      629           
  Lines      184948   184948           
  Branches    36204    36211    +7     
=======================================
+ Hits       166837   166843    +6     
+ Misses      11057    11045   -12     
- Partials     7054     7060    +6
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 95.04% <100.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65743/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66115/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit bc09144 into nodejs:main Apr 9, 2025
80 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bc09144

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@haykam821 @JonasBa
module: fix incorrect formatting in require(esm) cycle error message
c4bde7a 
Fixes: nodejs#57451
PR-URL: nodejs#57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@haykam821 @RafaelGSS
module: fix incorrect formatting in require(esm) cycle error message
81ad5b2 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@haykam821 @RafaelGSS
module: fix incorrect formatting in require(esm) cycle error message
0049147 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
aduh95 pushed a commit that referenced this pull request May 6, 2025
@haykam821 @aduh95
module: fix incorrect formatting in require(esm) cycle error message
29bfd78 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@haykam821 @RafaelGSS
module: fix incorrect formatting in require(esm) cycle error message
2716c24 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
aduh95 pushed a commit that referenced this pull request May 16, 2025
@haykam821 @aduh95
module: fix incorrect formatting in require(esm) cycle error message
44c4ceb 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
aduh95 pushed a commit that referenced this pull request May 17, 2025
@haykam821 @aduh95
module: fix incorrect formatting in require(esm) cycle error message
d0d0e31 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
aduh95 pushed a commit that referenced this pull request May 17, 2025
@haykam821 @aduh95
module: fix incorrect formatting in require(esm) cycle error message
dc77818 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
aduh95 pushed a commit that referenced this pull request May 17, 2025
@haykam821 @aduh95
module: fix incorrect formatting in require(esm) cycle error message
bd7b94f 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@haykam821 @aduh95
module: fix incorrect formatting in require(esm) cycle error message
44c5718 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jake Yuesong Li 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell
@marco-ippolito
Copy link
Member

This commit requires a manual backport to v20.x

@marco-ippolito marco-ippolito added backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Jun 5, 2025
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@jsumners-nr jsumners-nr jsumners-nr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad formatting in require(esm) module cycle error message
9 participants
@haykam821 @nodejs-github-bot @marco-ippolito @jasnell @lpinca @BridgeAR @jakecastelli @jsumners-nr @aduh95