Bug 1709415 - Support -webkit-image-set as a parse-time alias to image-set(). r=karlcow,twisniewski
ClosedPublic
Actions

Authored by emilio on May 12 2021, 12:51 AM.

Details

Reviewers

karlcow
twisniewski

Commits

rMOZILLACENTRAL01bca848cb09: Bug 1709415 - Support -webkit-image-set as a parse-time alias to image-set().

Bugzilla Bug ID

1709415

Summary

The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 320212
Build 414095: arc lint + arc unit

Event Timeline

emilio created this revision.May 12 2021, 12:51 AM

Herald added a project: secure-revision. · View Herald TranscriptMay 12 2021, 12:51 AM

Harbormaster completed remote builds in B319834: Diff 438035.May 12 2021, 12:51 AM

phab-bot published this revision for review.May 12 2021, 12:51 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

I let @twisniewski review the Rust code.
but the tests look good to me.

Thanks a lot @emilio

This revision is now accepted and ready to land.May 12 2021, 1:20 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!