Skip to content

Rename :open to :popover-open and remove :closed #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Rename :open to :popover-open and remove :closed #9077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5226aab
Rename :open to :popover and remove :closed
josepharhar Mar 27, 2023
c293cf9
rename to :popover-open
josepharhar Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72492,24 +72492,15 @@ Demos:
not null, or containing no elements, if it is.


:open
popover-open">:popover-open

The :open pseudo-class is defined to match
any HTML element whose

The popover-open">:popover-open pseudo-class is
defined to match any HTML element whose
data-x="attr-popover">popover attribute is not in the
data-x="attr-popover-none-state">no popover state and whose popover visibility
state is showing.

:closed

The :closed pseudo-class is defined to
match any HTML element whose
data-x="attr-popover">popover attribute is not in the
data-x="attr-popover-none-state">no popover state and whose popover visibility
state is hidden.

:enabled

The :enabled pseudo-class must match any
Expand Down Expand Up @@ -123575,10 +123566,11 @@ dialog::backdrop {
background: rgba(0,0,0,0.1);
}

[popover]:closed:not(dialog[open]) {
[popover]:not(:popover-open):not(dialog[open]) {
display:none;
}
dialog[popover]:not(:closed) {

dialog:popover-open {
display:block;
}

Expand All @@ -123595,7 +123587,7 @@ dialog[popover]:not(:closed) {
background-color: Canvas;
}

[popover]:open::backdrop {
:popover-open::backdrop {
position: fixed;
inset: 0;
pointer-events: none !important;
Expand Down