Skip to content

[text-box-trim] Add tests for multi-col #46470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

The text-box-trim should apply only to the top of the first
fragment and the bottom of the last fragment, resolved at
w3c/csswg-drafts#5335.

This patch adds tests for this, 001 for when the
text-box-trim is applied to the multicol container, and
002 for when a box with text-box-trim is block fragmented
by ancestor multicol.

Bug: 40254880
Change-Id: Ice29f39cbef0c20284edd809942754176a395d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564105
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1305545}

The `text-box-trim` should apply only to the top of the first
fragment and the bottom of the last fragment, resolved at
w3c/csswg-drafts#5335.

This patch adds tests for this, `001` for when the
`text-box-trim` is applied to the multicol container, and
`002` for when a box with `text-box-trim` is block fragmented
by ancestor multicol.

Bug: 40254880
Change-Id: Ice29f39cbef0c20284edd809942754176a395d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564105
Reviewed-by: Kent Tamura 
Commit-Queue: Kent Tamura 
Auto-Submit: Koji Ishii 
Cr-Commit-Position: refs/heads/main@{#1305545}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 592dc0a into master May 24, 2024
20 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-0f20138501 branch May 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants