Skip to content

ComputePressure: Turn sampleRate into sampleInterval #45213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

ComputePressure: Turn sampleRate into sampleInterval #45213

merged 1 commit into from
Mar 20, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 20, 2024 •
edited
Loading

Following specifications change[1], sampleRate in hertz is changed to
sampleInterval in millisecond.

w3c/compute-pressure#254

Bug: 330376756
Change-Id: Ibe909d537e462cd251d28c7d4d4702341dc33c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381598
Reviewed-by: Fr <[email protected]>
Reviewed-by: Raphael Kubo Da Costa <[email protected]>
Commit-Queue: Arnaud Mandy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1275582}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-5381598 branch 2 times, most recently from cc30dee to 110af76 Compare March 20, 2024 09:37
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title ComputePressure: reformat sampleRate to sampleInterval ComputePressure: Reformat sampleRate to sampleInterval Mar 20, 2024
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-5381598 branch 3 times, most recently from 99525d8 to 4edef7b Compare March 20, 2024 13:55
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title ComputePressure: Reformat sampleRate to sampleInterval ComputePressure: Turn sampleRate into sampleInterval Mar 20, 2024
@chromium-wpt-export-bot chromium-wpt-export-bot marked this pull request as ready for review March 20, 2024 15:25
wpt-pr-bot
wpt-pr-bot approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@arskama @jonathan-j-lee
ComputePressure: Turn sampleRate into sampleInterval
db53c45 
Following specifications change[1], sampleRate in hertz is changed to
sampleInterval in millisecond.

w3c/compute-pressure#254

Bug: 330376756
Change-Id: Ibe909d537e462cd251d28c7d4d4702341dc33c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381598
Reviewed-by: Fr 
Reviewed-by: Raphael Kubo Da Costa 
Commit-Queue: Arnaud Mandy 
Cr-Commit-Position: refs/heads/main@{#1275582}
@jonathan-j-lee jonathan-j-lee force-pushed the chromium-export-cl-5381598 branch from 8d9a1a5 to db53c45 Compare March 20, 2024 21:32
@jonathan-j-lee jonathan-j-lee merged commit 6ec99e5 into master Mar 20, 2024
@jonathan-j-lee jonathan-j-lee deleted the chromium-export-cl-5381598 branch March 20, 2024 22:04
BruceDai pushed a commit to BruceDai/wpt that referenced this pull request Mar 25, 2024
@chromium-wpt-export-bot @arskama @BruceDai
ComputePressure: Turn sampleRate into sampleInterval (web-platform-te…
6f782e6 
…sts#45213)

Following specifications change[1], sampleRate in hertz is changed to
sampleInterval in millisecond.

w3c/compute-pressure#254

Bug: 330376756
Change-Id: Ibe909d537e462cd251d28c7d4d4702341dc33c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381598
Reviewed-by: Fr 
Reviewed-by: Raphael Kubo Da Costa 
Commit-Queue: Arnaud Mandy 
Cr-Commit-Position: refs/heads/main@{#1275582}

Co-authored-by: Arnaud Mandy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export compute-pressure infra wg-das
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chromium-wpt-export-bot @wpt-pr-bot @jonathan-j-lee @arskama