Skip to content

Do not round the clipping region with mixed overflow clip #43858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 4, 2024

The CSSWG resolved [1] to not apply rounded border clipping when one of
overflow-x or overflow-y computes to clip and the other computes to
visible (https://drafts.csswg.org/css-overflow/#corner-clipping). This
patch updates our implementation to not create the inner border radius
clip in this mixed clip/visible scenario.

[1] w3c/csswg-drafts#7434

Bug: 1416649
Change-Id: I4d24ac82ecdafba5fa691efb1ce85892c734c717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171405
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1243240}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The CSSWG resolved [1] to not apply rounded border clipping when one of
overflow-x or overflow-y computes to clip and the other computes to
visible (https://drafts.csswg.org/css-overflow/#corner-clipping). This
patch updates our implementation to not create the inner border radius
clip in this mixed clip/visible scenario.

[1] w3c/csswg-drafts#7434

Bug: 1416649
Change-Id: I4d24ac82ecdafba5fa691efb1ce85892c734c717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171405
Reviewed-by: David Baron 
Commit-Queue: Philip Rogers 
Cr-Commit-Position: refs/heads/main@{#1243240}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7e7527c into master Jan 5, 2024
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5171405 branch January 5, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants