[Gecko Bug 1709415] Support -webkit-image-set as a parse-time alias to image-set(). #28972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webkit syntax is an strict subset of the modern one, so this should be doable, and is the simplest. If my reading of the WebKit code is correct it should also be the way WebKit deals with this (except they restrict -webkit-image-set() syntax artificially). * w3c/csswg-drafts#6285 * whatwg/compat#144 Differential Revision: https://phabricator.services.mozilla.com/D114912 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1709415 gecko-commit: 01bca848cb09b426c0c1c5f34d32dbe3fa5b9aa7 gecko-reviewers: karlcow, twisniewski
wpt-pr-bot
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.
If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).
Differential Revision: https://phabricator.services.mozilla.com/D114912
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1709415
gecko-commit: 01bca848cb09b426c0c1c5f34d32dbe3fa5b9aa7
gecko-reviewers: karlcow, twisniewski