[webcodecs] Support odd visibleRects

Per w3c/webcodecs#348 (comment),
Allow visibleRect to have odd size but not offset. Continue to restrict
copyTo() to even sizes.

Bug: 1205166
Change-Id: If6541a16a3852545634407c314530aaf40dc8e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293782
Reviewed-by: Chrome Cunningham 
Reviewed-by: Dale Curtis 
Commit-Queue: Dan Sanders 
Cr-Commit-Position: refs/heads/main@{#966946}

Author: Dan Sanders

webcodecs/videoFrame-construction.any.js

@@ -113,68 +113,85 @@ test(t => {
 
   assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: -1, y: 0, width: 10, height: 10}}),
-    'negative visibleRect x');
+      () => new VideoFrame(
+          image,
+          {timestamp: 10, visibleRect: {x: -1, y: 0, width: 10, height: 10}}),
+      'negative visibleRect x');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: 0, y: 0, width: -10, height: 10}}),
-    'negative visibleRect width');
+      () => new VideoFrame(
+          image,
+          {timestamp: 10, visibleRect: {x: 0, y: 0, width: -10, height: 10}}),
+      'negative visibleRect width');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: 0, y: 0, width: 10, height: 0}}),
-    'zero visibleRect height');
+      () => new VideoFrame(
+          image,
+          {timestamp: 10, visibleRect: {x: 0, y: 0, width: 10, height: 0}}),
+      'zero visibleRect height');
 
-    assert_throws_js(
-      TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: 0, y: Infinity, width: 10, height: 10}}),
-    'non finite visibleRect y');
+  assert_throws_js(
+      TypeError, () => new VideoFrame(image, {
+                   timestamp: 10,
+                   visibleRect: {x: 0, y: Infinity, width: 10, height: 10}
+                 }),
+      'non finite visibleRect y');
 
-    assert_throws_js(
-      TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: 0, y: 0, width: 10, height: Infinity}}),
-    'non finite visibleRect height');
+  assert_throws_js(
+      TypeError, () => new VideoFrame(image, {
+                   timestamp: 10,
+                   visibleRect: {x: 0, y: 0, width: 10, height: Infinity}
+                 }),
+      'non finite visibleRect height');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: 0, y: 0, width: 33, height: 17}}),
-    'visibleRect area exceeds coded size');
+      () => new VideoFrame(
+          image,
+          {timestamp: 10, visibleRect: {x: 0, y: 0, width: 33, height: 17}}),
+      'visibleRect area exceeds coded size');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, visibleRect: {x: 2, y: 2, width: 32, height: 16}}),
-    'visibleRect outside coded size');
+      () => new VideoFrame(
+          image,
+          {timestamp: 10, visibleRect: {x: 2, y: 2, width: 32, height: 16}}),
+      'visibleRect outside coded size');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
       () => new VideoFrame(image, {timestamp: 10, displayHeight: 10}),
-    'displayHeight provided without displayWidth');
+      'displayHeight provided without displayWidth');
 
-    assert_throws_js(
-      TypeError,
-      () => new VideoFrame(image, {timestamp: 10, displayWidth: 10}),
-    'displayWidth provided without displayHeight');
+  assert_throws_js(
+      TypeError, () => new VideoFrame(image, {timestamp: 10, displayWidth: 10}),
+      'displayWidth provided without displayHeight');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, displayWidth: 0, displayHeight: 10}),
-    'displayWidth is zero');
+      () => new VideoFrame(
+          image, {timestamp: 10, displayWidth: 0, displayHeight: 10}),
+      'displayWidth is zero');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(image, {timestamp: 10, displayWidth: 10, displayHeight: 0}),
-    'displayHeight is zero');
+      () => new VideoFrame(
+          image, {timestamp: 10, displayWidth: 10, displayHeight: 0}),
+      'displayHeight is zero');
 
-    assert_throws_js(
+  assert_throws_js(
       TypeError,
-      () => new VideoFrame(i420Frame, {visibleRect: {x: 1, y: 0, width: 2, height: 2}}),
+      () => new VideoFrame(
+          i420Frame, {visibleRect: {x: 1, y: 0, width: 2, height: 2}}),
       'visibleRect x is not sample aligned');
 
-    assert_throws_js(
-        TypeError,
-        () => new VideoFrame(i420Frame, {visibleRect: {x: 0, y: 0, width: 1, height: 2}}),
-        'visibleRect width is not sample aligned');
+  assert_throws_js(
+      TypeError,
+      () => new VideoFrame(
+          i420Frame, {visibleRect: {x: 0, y: 1, width: 2, height: 2}}),
+      'visibleRect y is not sample aligned');
 
 }, 'Test invalid CanvasImageSource constructed VideoFrames');
 
@@ -192,7 +209,8 @@ test(t => {
   ]);
   let origFrame = new VideoFrame(data, init);
 
-  let cropLeftHalf = new VideoFrame(origFrame, {visibleRect : {x: 0, y: 0, width: 2, height: 2}});
+  let cropLeftHalf = new VideoFrame(
+      origFrame, {visibleRect: {x: 0, y: 0, width: 2, height: 2}});
   assert_equals(cropLeftHalf.codedWidth, origFrame.codedWidth);
   assert_equals(cropLeftHalf.codedHeight, origFrame.codedHeight);
   assert_equals(cropLeftHalf.visibleRect.x, 0);
@@ -219,7 +237,8 @@ test(t => {
   ]);
   let anamorphicFrame = new VideoFrame(data, init);
 
-  let cropRightFrame = new VideoFrame(anamorphicFrame, {visibleRect : {x: 2, y: 0, width: 2, height: 2}});
+  let cropRightFrame = new VideoFrame(
+      anamorphicFrame, {visibleRect: {x: 2, y: 0, width: 2, height: 2}});
   assert_equals(cropRightFrame.codedWidth, anamorphicFrame.codedWidth);
   assert_equals(cropRightFrame.codedHeight, anamorphicFrame.codedHeight);
   assert_equals(cropRightFrame.visibleRect.x, 2);
@@ -246,7 +265,8 @@ test(t => {
   ]);
   let scaledFrame = new VideoFrame(data, init);
 
-  let cropRightFrame = new VideoFrame(scaledFrame, {visibleRect : {x: 2, y: 0, width: 2, height: 2}});
+  let cropRightFrame = new VideoFrame(
+      scaledFrame, {visibleRect: {x: 2, y: 0, width: 2, height: 2}});
   assert_equals(cropRightFrame.codedWidth, scaledFrame.codedWidth);
   assert_equals(cropRightFrame.codedHeight, scaledFrame.codedHeight);
   assert_equals(cropRightFrame.visibleRect.x, 2);
@@ -260,11 +280,12 @@ test(t => {
 test(t => {
   let image = makeImageBitmap(32, 16);
 
-  let scaledFrame = new VideoFrame(image,
-    { visibleRect : {x: 0, y: 0, width: 2, height: 2},
-      displayWidth: 10, displayHeight: 20,
-      timestamp: 0
-    });
+  let scaledFrame = new VideoFrame(image, {
+    visibleRect: {x: 0, y: 0, width: 2, height: 2},
+    displayWidth: 10,
+    displayHeight: 20,
+    timestamp: 0
+  });
   assert_equals(scaledFrame.codedWidth, 32);
   assert_equals(scaledFrame.codedHeight, 16);
   assert_equals(scaledFrame.visibleRect.x, 0);
@@ -553,6 +574,30 @@ test(t => {
   frame.close();
 }, 'Test we can construct a VideoFrame from an offscreen canvas.');
 
+test(t => {
+  let fmt = 'I420';
+  let vfInit = {
+    format: fmt,
+    timestamp: 1234,
+    codedWidth: 4,
+    codedHeight: 2,
+    visibleRect: {x: 0, y: 0, width: 1, height: 1},
+  };
+  let data = new Uint8Array([
+    1, 2, 3, 4, 5, 6, 7, 8,  // y
+    1, 2,                    // u
+    1, 2,                    // v
+    8, 7, 6, 5, 4, 3, 2, 1,  // a
+  ]);
+  let frame = new VideoFrame(data, vfInit);
+  assert_equals(frame.format, fmt, 'format');
+  assert_equals(frame.visibleRect.x, 0, 'visibleRect.x');
+  assert_equals(frame.visibleRect.y, 0, 'visibleRect.y');
+  assert_equals(frame.visibleRect.width, 1, 'visibleRect.width');
+  assert_equals(frame.visibleRect.height, 1, 'visibleRect.height');
+  frame.close();
+}, 'Test I420 VideoFrame with odd visible size');
+
 test(t => {
   let fmt = 'I420A';
   let vfInit = {format: fmt, timestamp: 1234, codedWidth: 4, codedHeight: 2};