Skip to content

Commit 6be88fd

Browse files
Web Share: restrict URL scheme to http and https
We now follow the recent spec change limiting the permitted scheme for shared urls to http and https - see w3c/web-share#173 w3c/web-share#174 w3c/web-share#177 We make an exception if the page performing the share it itself loaded from a different scheme (e.g. file) - in that case we allow the same scheme to be used for the shared url. Bug: 1131755 Change-Id: I6abf0f9acd40ef79ec49379314e2ef3a81d3467e
1 parent fbe1d22 commit 6be88fd

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

web-share/canShare.tentative.https.html

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,74 +11,74 @@
1111
'use strict';
1212

1313
test(() => {
14-
assert_equals(navigator.canShare(), false);
14+
assert_false(navigator.canShare());
1515
}, 'canShare with no arguments (same as empty dictionary)');
1616

1717
test(() => {
18-
assert_equals(navigator.canShare({}), false);
18+
assert_false(navigator.canShare({}));
1919
}, 'canShare with an empty dictionary');
2020

2121
test(() => {
22-
assert_equals(navigator.canShare(undefined), false);
22+
assert_false(navigator.canShare(undefined));
2323
}, 'canShare with a undefined argument (same as empty dictionary)');
2424

2525
test(() => {
26-
assert_equals(navigator.canShare(null), false);
26+
assert_false(navigator.canShare(null));
2727
}, 'canShare with a null argument (same as empty dictionary)');
2828

2929
test(() => {
30-
assert_equals(navigator.canShare({unused: 'unexpected field'}), false);
30+
assert_false(navigator.canShare({unused: 'unexpected field'}));
3131
}, 'canShare with a dictionary containing only surplus fields');
3232

3333
test(() => {
3434
// URL is invalid in that the URL Parser returns failure (port is too
3535
// large).
3636
const url = 'http://example.com:65536';
37-
assert_equals(navigator.canShare({url}), false);
37+
assert_false(navigator.canShare({url}));
3838
}, 'canShare with an invalid URL');
3939

4040
test(() => {
41-
assert_equals(navigator.canShare({title: undefined}), false);
41+
assert_false(navigator.canShare({title: undefined}));
4242
}, 'canShare with attribute undefined is equivalent to omitting the attribute');
4343

4444
test(() => {
45-
assert_equals(navigator.canShare({title: 'subject'}), true);
45+
assert_true(navigator.canShare({title: 'subject'}));
4646
}, 'canShare with title');
4747

4848
test(() => {
49-
assert_equals(navigator.canShare({text: 'body'}), true);
49+
assert_true(navigator.canShare({text: 'body'}));
5050
}, 'canShare with text');
5151

5252
test(() => {
53-
assert_equals(navigator.canShare({url: 'https://www.example.com/some/path?some_query#some_fragment'}), true);
53+
assert_true(navigator.canShare({url: 'https://www.example.com/some/path?some_query#some_fragment'}));
5454
}, 'canShare with URL');
5555

5656
test(() => {
57-
assert_equals(navigator.canShare({title: null}), true);
57+
assert_true(navigator.canShare({title: null}));
5858
}, 'canShare with null attribute');
5959

6060
test(() => {
61-
assert_equals(navigator.canShare({text: 123}), true);
61+
assert_true(navigator.canShare({text: 123}));
6262
}, 'canShare with number');
6363

6464
test(() => {
65-
assert_equals(navigator.canShare({url: {toString() { return 'https://example.com/'; }}}), true);
65+
assert_true(navigator.canShare({url: {toString() { return 'https://example.com/'; }}}));
6666
}, 'canShare with object');
6767

6868
test(() => {
69-
assert_equals(navigator.canShare({title: 'subject', text: 'body', url: 'https://example.com/', unused: 'unexpected field'}), true);
69+
assert_true(navigator.canShare({title: 'subject', text: 'body', url: 'https://example.com/', unused: 'unexpected field'}));
7070
}, 'canShare with unexpected field');
7171

7272
test(() => {
73-
assert_equals(navigator.canShare({url: 'data:the url'}), true);
73+
assert_false(navigator.canShare({url: 'data:the url'}));
7474
}, 'canShare with data URL');
7575

7676
test(() => {
77-
assert_equals(navigator.canShare({url: ''}), true);
77+
assert_true(navigator.canShare({url: ''}));
7878
}, 'canShare with empty URL');
7979

8080
test(() => {
81-
assert_equals(navigator.canShare({url: '//www.example.com/some/path?some_query#some_fragment'}), true);
81+
assert_true(navigator.canShare({url: '//www.example.com/some/path?some_query#some_fragment'}));
8282
}, 'canShare with URL having no scheme');
8383
script>
8484
body>

0 commit comments

Comments
 (0)