Handle display:contents for viewport propagation.

lilles · chromium-wpt-export-bot · commit 00ccaab65410 · 2019-07-24T07:12:11.000-07:00
When documentElement/body doe not generate a box, its background will not propagate to the viewport (see [1]). This removes the need for calling EnsureComputedStyle() on documentElement/body. The CSSWG has also resolved that to be the case also for other properties propagated to the viewport[2]. Some of the wpt tests for body propagation didn't actually have a body element. Added. [1] https://drafts.csswg.org/css-backgrounds/#special-backgrounds [2] w3c/csswg-drafts#3779 (comment) Bug: 987207 Change-Id: I06e618e2acd2926b5ae4831bf5825e13e970d035
diff --git a/css/css-backgrounds/background-color-body-propagation-004.html b/css/css-backgrounds/background-color-body-propagation-004.html
@@ -8,3 +8,4 @@
     display: none
   }
 </style>
+<body></body>
diff --git a/css/css-backgrounds/background-color-body-propagation-005.html b/css/css-backgrounds/background-color-body-propagation-005.html
@@ -6,3 +6,4 @@
   html { display: none; }
   body { background: red; }
 </style>
+<body></body>
diff --git a/css/css-backgrounds/background-color-body-propagation-006.html b/css/css-backgrounds/background-color-body-propagation-006.html
@@ -14,3 +14,4 @@
     }));
   };
 </script>
+<body></body>
diff --git a/css/css-backgrounds/background-color-body-propagation-007.html b/css/css-backgrounds/background-color-body-propagation-007.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<title>CSS Backgrounds and Borders Test: don't propagate body background when display:contents</title>
+<link rel="help" href="https://drafts.csswg.org/css-backgrounds/#special-backgrounds">
+<link rel="match" href="../reference/blank.html">
+<style>
+  body {
+    background: red;
+    display: contents
+  }
+</style>
+<body></body>
diff --git a/css/css-overflow/overflow-body-propagation-001.html b/css/css-overflow/overflow-body-propagation-001.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<title>CSS Overflow Test: Propagation of body overflow to viewport</title>
+<link rel="help" href="https://drafts.csswg.org/css-overflow/#overflow-propagation">
+<link rel="match" href="reference/overflow-body-propagation-ref.html">
+<style>
+  body {
+    overflow: scroll;
+    margin-top: 100px;
+  }
+</style>
+<body>The viewport should have scrollbars, not the body.</body>
diff --git a/css/css-overflow/overflow-body-propagation-002.html b/css/css-overflow/overflow-body-propagation-002.html
@@ -0,0 +1,5 @@
+<!doctype html>
+<title>CSS Overflow Test: Do not propagate overflow of display:none body to viewport</title>
+<link rel="help" href="https://drafts.csswg.org/css-overflow-3/#overflow-propagation">
+<link rel="match" href="/css/reference/blank.html">
+<body style="display:none; overflow:scroll"></body>
diff --git a/css/css-overflow/overflow-body-propagation-003.html b/css/css-overflow/overflow-body-propagation-003.html
@@ -0,0 +1,5 @@
+<!doctype html>
+<title>CSS Overflow Test: Do not propagate overflow of display:contents body to viewport</title>
+<link rel="help" href="https://drafts.csswg.org/css-overflow-3/#overflow-propagation">
+<link rel="match" href="/css/reference/blank.html">
+<body style="display:contents; overflow:scroll"></body>
diff --git a/css/css-overflow/overflow-body-propagation-004.html b/css/css-overflow/overflow-body-propagation-004.html
@@ -0,0 +1,13 @@
+<!doctype html>
+<link rel="help" href="https://drafts.csswg.org/css-overflow/#overflow-propagation">
+<link rel="match" href="reference/overflow-body-no-propagation-ref.html">
+<style>
+  html {
+    overflow: hidden;
+  }
+  body {
+    overflow: scroll;
+    margin-top: 100px;
+  }
+</style>
+<body>The body should have scrollbars, not the viewport.</body>
diff --git a/css/css-overflow/reference/overflow-body-no-propagation-ref.html b/css/css-overflow/reference/overflow-body-no-propagation-ref.html
@@ -0,0 +1,5 @@
+<!doctype html>
+<html style="overflow:auto">
+<title>CSS Overflow Test Reference</title>
+<body style="margin-top:100px;overflow:scroll">The body should have scrollbars, not the viewport.</body>
+</html>
diff --git a/css/css-overflow/reference/overflow-body-propagation-ref.html b/css/css-overflow/reference/overflow-body-propagation-ref.html
@@ -0,0 +1,5 @@
+<!doctype html>
+<html style="overflow:scroll">
+<title>CSS Overflow Test Reference</title>
+<body style="margin-top:100px">The viewport should have scrollbars, not the body.</body>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -8,3 +8,4 @@`
`8`	`8`	`display: none`
`9`	`9`	`}`
`10`	`10`	`style>`
	`11`	`+<body>body>`
-Original file line number
+Diff line change
   html { display: none; }
   body { background: red; }
 style>
 +<body>body>