Skip to content

feat!: remove constructor from ConsumedThing interface #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 28, 2023

Would resolve #516 and close #515 (as an alternative PR).


Preview | Diff

@JKRhb JKRhb changed the title feat!: remove constructor from ExposedThing interface feat!: remove constructor from ConsumedThing interface Oct 29, 2023
@zolkis
Copy link
Contributor

zolkis commented Oct 29, 2023

This needs more work across the spec, as just removing the IDL alone is not consistent with the text.
Align for both ExposedThing and ConsumedThing, change "Constructing" to "Create" for the factored out steps, check the factory method steps, etc.

@danielpeintner
Copy link
Contributor

Scripting API call Nov 20

  • group is okay with the change

@danielpeintner danielpeintner merged commit 044c2d3 into w3c:main Nov 20, 2023
@JKRhb JKRhb deleted the consumedthing-constructor-removal branch November 20, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a constructor to both the WebIDL and TypeScript definitions of the ExposedThing interface
4 participants