Skip to content

Improve error handling for ExposedThing:emitEvent() #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

Improve error handling for ExposedThing:emitEvent() #269

merged 1 commit into from
Oct 7, 2020

Conversation

zolkis
Copy link
Contributor

@zolkis zolkis commented Oct 5, 2020 •
edited by pr-preview bot
Loading

Signed-off-by: Zoltan Kis [email protected]

Preview | Diff

@danielpeintner danielpeintner mentioned this pull request Oct 5, 2020
Closed
danielpeintner
danielpeintner approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically correct and good to go.

Other improvements can follow later...

@zolkis
Copy link
Contributor Author

zolkis commented Oct 7, 2020

Merging this then.

@zolkis zolkis merged commit 7a5d14a into w3c:master Oct 7, 2020
@zolkis zolkis deleted the error-handling branch November 11, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpeintner danielpeintner danielpeintner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zolkis @danielpeintner