-
Notifications
You must be signed in to change notification settings - Fork 288
Update errata/21.html for previous publications #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to run this past Kevin before changing the format of the ToC, since this is a holdover from before the errata was migrated into this repo. (I am personally not opposed to the change)
https://www.w3.org/TR/{{ trDate | split: "-" | first }}/REC-WCAG{{ page.fileSlug }}-{{ trDate | replace: "-", "" }}/ | ||
{%- endcapture -%} | ||
<section id="since-{{ trDate }}"> | ||
<h2>Errata since <a href="{{ trUrl }}">{{ trDate | date: "%d %B %Y" }} Publicationa>h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding something like ", first publication as final W3C Technical Report" but I defer to your and Kevin's judgment on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by this comment:
- The 2023 republication, which this is commenting on, is not the first publication of the recommendation
- Is "Technical Report" distinct from "Recommendation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with PR as-is.
- Some references are to GitHub PRs instead of commits. Would it be easy (and desirable) for those to all be commits? This is mostly for the sake of consistency.
- Is it not possible to pick a date for the last (i.e., bottom-most) item?
In the Status of This Document, removing the first instance of the repeated paragraph beginning "This document has been reviewed by W3C Members...".
My thought process is that linking to PRs is preferable when possible, because they provide more context. Typically this will only not be feasible for modern 2.1 backports (which in the most recent case I performed via a single PR but then intentionally rebase-merged rather than squashed), in which case the commit message does still include a link to the PR.
When I first migrated this page into the repo, that was the only change I was not able to trace to a particular commit. |
This documents the errata that occurred since each of the 2 previous (not current) publications, i.e. the publications in September 2023 and December 2024.
This directly references commit hashes on the WCAG-2.1 branch and their respective dates (which occurred later), rather than referencing the original pull requests and the dates they were merged into main.
https://deploy-preview-4424--wcag2.netlify.app/errata/21