Skip to content

Update errata/21.html for previous publications #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Jun 3, 2025

This documents the errata that occurred since each of the 2 previous (not current) publications, i.e. the publications in September 2023 and December 2024.

This directly references commit hashes on the WCAG-2.1 branch and their respective dates (which occurred later), rather than referencing the original pull requests and the dates they were merged into main.

https://deploy-preview-4424--wcag2.netlify.app/errata/21

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 672129f
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/683ee9028fe6970008cf4cc1
😎 Deploy Preview https://deploy-preview-4424--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mbgower mbgower self-requested a review June 9, 2025 16:13
mbgower
mbgower previously requested changes Jun 9, 2025
Copy link
Contributor

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we reduce the TOC to only the H2s (i.e., leave out the secondary entries for each publication date.
Screenshot 2025-06-09 at 9 14 41 AM

@kfranqueiro kfranqueiro dismissed mbgower’s stale review June 9, 2025 16:46

I'm going to run this past Kevin before changing the format of the ToC, since this is a holdover from before the errata was migrated into this repo. (I am personally not opposed to the change)

https://www.w3.org/TR/{{ trDate | split: "-" | first }}/REC-WCAG{{ page.fileSlug }}-{{ trDate | replace: "-", "" }}/
{%- endcapture -%}
<section id="since-{{ trDate }}">
<h2>Errata since <a href="{{ trUrl }}">{{ trDate | date: "%d %B %Y" }} Publicationa>h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding something like ", first publication as final W3C Technical Report" but I defer to your and Kevin's judgment on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by this comment:

  • The 2023 republication, which this is commenting on, is not the first publication of the recommendation
  • Is "Technical Report" distinct from "Recommendation"?

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with PR as-is.

  1. Some references are to GitHub PRs instead of commits. Would it be easy (and desirable) for those to all be commits? This is mostly for the sake of consistency.
  2. Is it not possible to pick a date for the last (i.e., bottom-most) item?

In the Status of This Document, removing the first instance of the repeated paragraph beginning "This document has been reviewed by W3C Members...".

@kfranqueiro
Copy link
Contributor Author

kfranqueiro commented Jun 9, 2025

  1. Some references are to GitHub PRs instead of commits. Would it be easy (and desirable) for those to all be commits? This is mostly for the sake of consistency.

My thought process is that linking to PRs is preferable when possible, because they provide more context. Typically this will only not be feasible for modern 2.1 backports (which in the most recent case I performed via a single PR but then intentionally rebase-merged rather than squashed), in which case the commit message does still include a link to the PR.

  1. Is it not possible to pick a date for the last (i.e., bottom-most) item?

When I first migrated this page into the repo, that was the only change I was not able to trace to a particular commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants