Skip to content

Audio description failure technique #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented May 9, 2025

Closes #3806
Closes #1768 (in combination with the other previously merged changes outlined in #1768 (comment))

Creates a failure technique to show the conditions under which a video fails 1.2.5 due to important visual information not being described in pauses in the dialogue

Preview

mbgower and others added 6 commits April 7, 2025 08:18
Change to informative content (a note) in normative content (definition):

Added the word "important" to note 3 to match the wording of the definition (which reads "..to describe important visual details...").
Two changes to the first note in the informative Understanding document:

- add "additional" to match the first change to the definition note.
- swap out the word "provided" in preference for the synonym "conveyed"

This change is made in the belief that is more accurate. For example, if a scene shows something blowing up, and there is the sound of an explosion that matches, it is more accurate to say the sound conveys the visual explosion than to say the sound "provides" the visual explosion.
Addresses #1768

Creates a failure technique to show the conditions under which a video fails 1.2.5 due to important visual information not being described in pauses in the dialogue
@mbgower mbgower mentioned this pull request May 9, 2025
Copy link

netlify bot commented May 9, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit f8c000b
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/684345750da2de000827d281
😎 Deploy Preview https://deploy-preview-4390--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion. otherwise this makes sense to me - and the other delving into the applicability or essential nature of a pause can be handled in content to be added to the understanding doc

mbgower and others added 3 commits May 12, 2025 06:55
I've removed "must" to address Scott's concern
Remove note styling and add in wording suggested in #3806
I think it may look better with the note. Trying to retain just for the pre-existing paragraph to see how that looks

For each occurrence of synchronized time-based media:

  • Check that all important visual information has been conveyed in the narration.
  • Check that narration has been added in all appropriate pauses in the dialogue.
  • Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Check that audio description is provided for any visual information necessary to understand the content which is not conveyed by audio in the synchronized media.

    Copy link
    Contributor Author

    @mbgower mbgower May 12, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This second check is there to make sure any available appropriate pauses are used.
    The first check has already validated that the audio descriptions either cover all the material, or they don't.
    Here, we're testing that all the pauses have been used for narration.
    Together they give us the gates for the failure:
    #1 passes= no failure
    #1 fails and #2 passes=no failure
    #1 fails, #2 fails=failure

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The original working is actually checking that all possibly useful pauses are used, which may not be appropriate.

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This failure test goes beyond the SC. The SC does not require that ALL important information be conveyed. Nor does it require that all gaps be used. There is a good reason for both

    1. there are not enough gaps in the right places to describe all important information for many or most video. So it was not required or else we would have had to make it level AAA because it could not be applied to all (or even most) video. So the SC only requires that SOME but not ALL important info be provided

    2. it does not require that all gaps be used because a gap that appears at a place where there is no important information cannot be used to describe somethig that happened a long time ago. Also - some gaps are too small to be used.

    So a failure that implies or tests for all important information or all gaps to be used -- is not a valid failure since it is testing for things not in the SC. In addition it would be something that would fail the best attempts at audio description for many videos.

    Copy link
    Member

    @patrickhlauke patrickhlauke May 30, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    i assume this was in response to my comment here #4390 (comment) rather than andrew's from 3 weeks ago...

    also, you seem to be commenting on an outdated snippet that has already been changed/superseded. it might be worth going via https://github.com/w3c/wcag/pull/4390/files to check what the actual latest state of the PR is to avoid that...

    Copy link
    Contributor

    @kfranqueiro kfranqueiro left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @mbgower your last commits seem to have somehow reverted F113 to an empty file?

    This reverts commit a2213d6.
    @kfranqueiro kfranqueiro requested review from kfranqueiro and removed request for kfranqueiro June 5, 2025 10:45
    @kfranqueiro kfranqueiro dismissed their stale review June 5, 2025 10:46

    Resolved issue with file by reverting the commit that emptied it

    mbgower and others added 4 commits June 5, 2025 06:05
    Update to respond to Patrick's feedback
    Added terminal punctuation to each list item
    Made it a series of "if not" statemtns
    @awkawk
    Copy link
    Member

    awkawk commented Jun 6, 2025

    What if the third check was:
    Check that there are no remaining pauses in dialog where it is appropriate to add audio description.

    And then the failure would be triggered when all three checks are false?

    @mbgower
    Copy link
    Contributor Author

    mbgower commented Jun 6, 2025

    What if the third check was: Check that there are no remaining pauses in dialog where it is appropriate to add audio description.

    And then the failure would be triggered when all three checks are false?

    Incorporated.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Creating a new sufficient technique using audio ducking to create audio descriptions How to add audio descriptions to videos?
    8 participants