-
Notifications
You must be signed in to change notification settings - Fork 289
Time based media EO references #4339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change to informative content (a note) in normative content (definition): Added the word "important" to note 3 to match the wording of the definition (which reads "..to describe important visual details...").
Two changes to the first note in the informative Understanding document: - add "additional" to match the first change to the definition note. - swap out the word "provided" in preference for the synonym "conveyed" This change is made in the belief that is more accurate. For example, if a scene shows something blowing up, and there is the sound of an explosion that matches, it is more accurate to say the sound conveys the visual explosion than to say the sound "provides" the visual explosion.
This change aligns the guidance in the Understanding documents with the SC text for 1.2.7. The preamble for 1.2.7 states "Where pauses in foreground audio are insufficient to allow audio descriptions to convey the send of the video..." Based on that preamble, it makes no sense for note 1 to reference 1.2.7, since if all important information is "already conveyed in the audio track", it will never meet the preamble condition. This logic is confirmed by the fact that note 1 has never existed in the 1.2.7 Understanding document.
Only one note exists in 1.2.8; however, it contains multiple paragraphs which are enumerated as separate notes in 1.2.3 and 1.2.5. The first paragraph of 1.2.8, which corresponds to note 1 in 1.2.3 and 1.2.5, is irrelevant to 1.2.8. By removing this paragraph, 1.2.8 is reduced to coverrng a single concept, which results in an unnumbered note, by convention.
- Added the word "additional" to note 1 - Added a new technique "Providing audio descriptions by incorporating narration into the existing soundtrack"
Changed the preposition from "into" to "to"
Updated the ID, and made editorial changes to improve the new technique
Removed the references to a slide presentation
Thanks @mbgower ! I only had time for a quick skim. A minor request: "W3C Web Accessibility Initiative" -> "W3C Web Accessibility Initiative (WAI)" Will this get propagated to Understanding docs for 2.1 & 2.2, too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
understanding/20/audio-description-or-media-alternative-prerecorded.html
Outdated
Show resolved
Hide resolved
Adjusted as per request
Done
We do not touch the 2.0 space, but it will appear in 2.2 and 2.1 versions. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Based on comments stripped out the adjective so it just covers narration added to the soundtrack
fixes #4341 by addressing minor typos
resolves #4341 outstanding typos as well. |
Co-authored-by: Patrick H. Lauke
Co-authored-by: Patrick H. Lauke
Co-authored-by: Patrick H. Lauke
Co-authored-by: Patrick H. Lauke
Co-authored-by: Patrick H. Lauke
There seem to remain a number of defunct links to techniques like the SMIL techniques - not sure if they produce a 404 error due to the way I rendered the file or whether this is to be left to another PR. |
Which page are you talking about? On the current live page for captions (prerecorded), those seem fine. |
I was talking about "Understanding Audio Description or Media Alternative (Prerecorded)" - I just went to "Files changed" in this PR and then "View file" and put the URL of that through Githack with this result - but in that view all the Techniques URLs don't work - so forget it... |
note that thanks to the magic of @kfranqueiro you don't need to manually go via githack or similar ... just use the netlify deploy preview #4339 (comment) … https://deploy-preview-4339--wcag2.netlify.app/ in your specific case https://deploy-preview-4339--wcag2.netlify.app/understanding/audio-description-or-media-alternative-prerecorded |
Co-authored-by: Hidde de Vries <[email protected]>
Hmm. The useful thing would be to have that full link in the PR straight away, rather than having to construct it by concatenating the netlify stump with the rest of the path - especially as it is not even the path that can be copied directly from the "Files changed" tab ( @kfranqueiro Would it be possible to generate the full path for the deploy preview, so there is nothing left to be done for reviewers but just clicking it? |
with PRs that touch lots and lots of files, that would ... become a bit unwieldy. i've personally been okay (with a bit of inside knowledge of what/where files are once they're actually published) with just going to the preview root, and then go "ok, this PR updates the understanding for X, let me navigate to the understanding page for that..." from the root. |
For PRs where a single page is of interest, it is possible to control what path within the deploy the Netlify preview comment links to by including a line like the following in the PR description:
But it still can only reference a single path. (I did this in #4391 for example) |
235e889
to
12c8585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw the latest merge commit hit this branch, and it now lists 23 commits. I have a feeling this got confused with the chain of PRs landed earlier this week; we should take another look at rebasing this before merging.
@kfranqueiro I just had a look, and it seems fine. I already resolved the conflict that existed on note 1 for 1.2.3 and 1.2.5 |
understanding/20/audio-description-or-media-alternative-prerecorded.html
Outdated
Show resolved
Hide resolved
I took out a couple of extra line breaks to make the diff cleaner |
I took a closer look this morning; the diff does seem correct, despite the commit history looking convoluted. Looking more closely, it looks like one of the rebases/merges earlier in the week did impact the commit history, so there are redundant commits shown in the commits tab on this PR that should collapse down to no changes.
fulfils request from @shawna-slh :
I added an items to the Resources section of the A and AA Understanding docs, and in AAA where there was material that seemed to be specific to the SC. Six in total.
Also
resolves #4341
I added in some trivial corrections to the 1.2 Time-based media understanding doc to close a recent issue.