-
Notifications
You must be signed in to change notification settings - Fork 288
Tweak understanding for 1.2.3 and 1.2.5 #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrickhlauke
wants to merge
17
commits into
main
Choose a base branch
from
patrickhlauke-understanding-audiodescription
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
92fe9f2
Tweak understanding for 1.2.3 and 1.2.5
patrickhlauke 0b9920b
Expand audio description note to mention lowering of bg music/sounds
patrickhlauke 42999ac
Change "will also" to "may"
patrickhlauke f91c843
Update guidelines/terms/20/audio-description.html
patrickhlauke dbe5c72
Revert change to AD definition
patrickhlauke 6fea6ac
Remove suggestion to "duck" less-important audio/dialogue
patrickhlauke aef783b
Add new para about using media alternative when no gaps in dialog
patrickhlauke 0a9a274
Update understanding/20/audio-description-or-media-alternative-prerec…
mbgower c428203
Update understanding/20/audio-description-prerecorded.html
mbgower 8fed83f
Update understanding/20/audio-description-prerecorded.html
mbgower 33420d3
Merge branch 'main' into patrickhlauke-understanding-audiodescription
patrickhlauke 3c1c453
Markup cleanup
patrickhlauke 86adef7
Further language tweaks
patrickhlauke 28d3c0b
Merge branch 'main' into patrickhlauke-understanding-audiodescription
patrickhlauke 424ba20
Add reference to 1.2.7
patrickhlauke 529e14e
Merge branch 'main' into patrickhlauke-understanding-audiodescription
kfranqueiro 7d16fb6
Merge branch 'main' into patrickhlauke-understanding-audiodescription
patrickhlauke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change "will also" to "may"
- Loading branch information
commit 42999acd1f16820d888f73d79c4c7ecf606de0cb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
other visual content. | ||
|
||
In standard audio description, narration is added during existing pauses in dialogue. Usually, this will also require |
||
In standard audio description, narration is added during existing pauses in dialogue. Usually, this may require |
||
lowering the volume of background music and other non-informational sounds. (See also extended audio description.) | ||
patrickhlauke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.