Skip to content

Update ARIA11 #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update ARIA11 #1023

wants to merge 5 commits into from

Conversation

JAWS-test2
Copy link
Contributor

Fixes #919

Also:

  • Update and addition of links
  • Remove role=application (no landmark region)
  • Adding role=region
  • Adding the test for meaningful labeling

Base automatically changed from master to main March 5, 2021 20:42
@kfranqueiro kfranqueiro removed the request for review from michael-n-cooper May 5, 2025 13:17
Copy link

netlify bot commented May 5, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 6bdd100
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/684223e5c67a060008ee2ee7
😎 Deploy Preview https://deploy-preview-1023--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kfranqueiro
Copy link
Contributor

I synced this branch today while looking through old PRs, which required resolving conflicts:

  • In the list of landmarks, I only kept the banner change (which concerns the referenced bug); application had since been removed, navigation had since been changed to something similar to what was in this PR, and region had since been added. I did correct one duplicated word in the navigation item.
  • The modification of one line of the first example was no longer applicable as the example had changed
  • Preserved the addition to the test prodecure, although I wonder if items 3 and 4 could be merged?
  • Preserved the additions under related techniques
  • Preserved the changes to the first 3 resource links; the 4th is already pointing to a newer URL for what was added in this PR, and the 5th was added after this PR

See df64f09e for what was in the original commit of this PR.

kfranqueiro and others added 2 commits May 5, 2025 10:11
Co-authored-by: Scott O'Hara 
@@ -112,12 +112,13 @@

Procedure

  • Examine each element with a landmark role.
  • Examine whether the correct element has been used to mark up content. For example: a navigation role has been used to mark up a section with navigation links, or the main role is used to contain the page's main content.
  • If a landmark region needs to have an accessible name to be exposed as a landmark, check to see that there is an accessible name.
  • Examine that each landmark region that appears multiple times on the page is labelled meaningfully.
  • Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggesting a change to phrase the new check conditionally, similar to the previous one:

    Suggested change
    <li>Examine that each landmark region that appears multiple times on the page is labelled meaningfully.li>
    <li>If the same type of landmark appears multiple times on the page, check that each one is labelled meaningfully.li>

    @mbgower mbgower self-assigned this May 16, 2025
    @bruce-usab
    Copy link
    Contributor

    Discussed on backlog call 5/16. We did not resolve if "each landmark region" was equivalent to "same type of landmark".

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    ARIA11 update the banner definition
    6 participants