Skip to content
This repository was archived by the owner on Sep 19, 2018. It is now read-only.

Commit 9bcd7df

Browse files
bzbarskyjgraham
authored andcommitted
Fix iterable testing to add actual members to our list of members; otherwise all sorts of stuff breaks (#243)
1 parent 6ea11dc commit 9bcd7df

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

idlharness.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,12 +1382,17 @@ IdlInterface.prototype.do_member_operation_asserts = function(memberHolderObject
13821382
IdlInterface.prototype.add_iterable_members = function(member)
13831383
//@{
13841384
{
1385-
this.members.push({type: "operation", name: "entries", idlType: "iterator", arguments: []});
1386-
this.members.push({type: "operation", name: "keys", idlType: "iterator", arguments: []});
1387-
this.members.push({type: "operation", name: "values", idlType: "iterator", arguments: []});
1388-
this.members.push({type: "operation", name: "forEach", idlType: "void", arguments:
1389-
[{ name: "callback", idlType: {idlType: "function"}},
1390-
{ name: "thisValue", idlType: {idlType: "any"}, optional: true}]});
1385+
this.members.push(new IdlInterfaceMember(
1386+
{ type: "operation", name: "entries", idlType: "iterator", arguments: []}));
1387+
this.members.push(new IdlInterfaceMember(
1388+
{ type: "operation", name: "keys", idlType: "iterator", arguments: []}));
1389+
this.members.push(new IdlInterfaceMember(
1390+
{ type: "operation", name: "values", idlType: "iterator", arguments: []}));
1391+
this.members.push(new IdlInterfaceMember(
1392+
{ type: "operation", name: "forEach", idlType: "void",
1393+
arguments:
1394+
[{ name: "callback", idlType: {idlType: "function"}},
1395+
{ name: "thisValue", idlType: {idlType: "any"}, optional: true}]}));
13911396
};
13921397

13931398
//@}

0 commit comments

Comments
 (0)