-
Notifications
You must be signed in to change notification settings - Fork 135
Integrate with Feature Policy #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b24a70c
Editorial: relationship to Feature Policy spec
8f10817
allowpaymentrequest is now in Feature Policy
1ce1ac5
Review feedback
7679151
Normatively define payment feature
2cb7a95
Merge branch 'gh-pages' into feature_policy
marcoscaceres f1e80d6
typo
domenic 1d9a28a
Review nit
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -617,13 +617,11 @@ | |
act as follows: | ||
|
||
"allowpaymentrequest/active-document-cross-origin.https.sub.html, allowpaymentrequest/active-document-same-origin.https.html, allowpaymentrequest/removing-allowpaymentrequest.https.sub.html, allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html, allowpaymentrequest/setting-allowpaymentrequest.https.sub.html"> | ||
If the current settings object's | ||
marcoscaceres marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
"HTML#responsible-document">responsible document is not | ||
allowed to use the feature indicated by attribute name | ||
allowpaymentrequest, then throw a | ||
"SecurityError" DOMException. | ||
allowed to use the "payment" | ||
feature, then throw a "SecurityError" | ||
DOMException. | ||
|
||
|
@@ -3475,12 +3473,49 @@ | |
PaymentRequest and iframe elements |
||
"allowpaymentrequest/active-document-cross-origin.https.sub.html, allowpaymentrequest/active-document-same-origin.https.html, allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html, allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html, allowpaymentrequest/basic.https.html, allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html, allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html, allowpaymentrequest/removing-allowpaymentrequest.https.sub.html, allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html, allowpaymentrequest/setting-allowpaymentrequest.https.sub.html"> | ||
To indicate that a cross-origin iframe is allowed to invoke the | ||
payment request API, the allowpaymentrequest attribute can be | ||
specified on the iframe element. | ||
specified on the iframe element. See | ||
"#feature-policy"> for details of how allowpaymentrequest | ||
and Feature Policy interact. | ||
Feature Policy integration | ||
This specification defines a policy-controlled feature identified by | ||
the string "
|
||
"">payment". Its | ||
"feature-policy#default-allowlist">default allowlist is | ||
'self '. |
||
A document’s | ||
"html/multipage/dom.html#concept-document-feature-policy">feature | ||
policy determines whether any content in that document is allowed | ||
to construct PaymentRequest instances. If disabled in any | ||
document, no content in the document will be allowed to use | ||
the PaymentRequest constructor (trying to create an instance | ||
will throw). | ||
The allowpaymentrequest attribute of the HTML iframe | ||
element affects the | ||
"feature-policy#container-policy">container policy for any | ||
document nested in that iframe. Unless overridden by the | ||
|
||
"html/multipage/iframe-embed-object.html#attr-iframe-allow">allow | ||
attribute, setting allowpaymentrequest on an iframe is | ||
equivalent to <iframe allow="fullscreen *"> , as |
||
described in | ||
"feature-policy#iframe-allowpaymentrequest-attribute">Feature Policy | ||
§iframe-allowpaymentrequest-attribute. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests will be moving to Feature Policy directory as part of web-platform-tests/wpt#14855