Remove PaymentAddress' languageCode #765
Conversation
|
Updated MDN, and sent a PR to WTP to remove |
|
Chairs, we should decide on a timeframe for feedback on this from the community. 1 month CFC? I'm going to remove from Gecko in the mean time. Can always revert it later if we need it. |
|
The usage counter will inform our decision to remove the languageCode immediately or after some developer outreach. |
Great! Will you be notified automatically once the results are collected? I'll wait for your results before merging. |
I wish! I have a calendar reminder to check the data :-) |
Good enough 👍 |
|
Removed from Firefox. |
|
I've removed it from Safari as well. |
|
@marcoscaceres please tag me or @mountainhippo if you need anything from the chairs. Only saw this now. @ianbjacobs is this covered by process? We never marked this as at risk previously |
|
Hi all, I had hoped we would hold off merging until after the CfC. That is why the draft CfC I circulated pointed to the pull request. My expectation was to merge after the CfC. Ian |
|
Yep, that’s the plan. It’s actually to wait for @rsolomakhin to gather data from Chrome before we make a final decision. |
|
Call for Consensus: |
marcoscaceres
force-pushed
the
remove_language_cod
branch
from
e8c3423 to
6b656bf
Compare
|
@rsolomakhin, how’s that data looking? Any chance we will know by TPAC? We’ve removed this from Firefox and it’s also gone from Safari. Hopefully it’s all good news on the Chrome side. |
|
Data shows we can remove from Chrome. I've sent out the intent to deprecate. |
|
So, we will print a deprecation warning in developer console for a couple of months, then will remove it outright. |
|
Awesome, thanks for confirming and doing the due diligence! Going to merge this then. |
w3c/payment-request#765 and w3c/payment-request#823 removed the languageCode and regionCode members from the PaymentAddress interface. w3c/payment-request@3fb7e37 w3c/payment-request@5906b72
w3c/payment-request#765 and w3c/payment-request#823 removed the languageCode and regionCode members from the PaymentAddress interface. w3c/payment-request@3fb7e37 w3c/payment-request@5906b72
closes #608
The following tasks have been completed:
Implementation commitment:
Impact on Payment Handler spec?
None
Preview | Diff