Skip to content

Check doc fully active during response.complete() #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2018

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 5, 2018

closes #731

The following tasks have been completed:


Preview | Diff

@marcoscaceres marcoscaceres requested a review from domenic July 5, 2018 21:59
index.html Outdated
  • Otherwise, close down any remaining user interface. The user
  • Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Maybe all three of these steps should be under "otherwise"? Doesn't actually have normative impact, but seems cleaner.

    @marcoscaceres
    Copy link
    Member Author

    Tested as part of web-platform-tests/wpt#11101 which is still in review.

    @marcoscaceres marcoscaceres merged commit a0ff44f into gh-pages Jul 16, 2018
    @marcoscaceres marcoscaceres deleted the complete_doc_check branch July 16, 2018 20:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Do we need "doc is fully active" checks on response.complete()?
    2 participants