-
Notifications
You must be signed in to change notification settings - Fork 135
Spread resolved data
on updateWith()
#669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's better to stay at the Infra level than to drop down to the ECMAScript level. Otherwise what happens here will be different if someone monkeys with Object.prototype, for example. You'll need to define some kind of ordered map merging operation, or let us do that for you in Infra.
BUT, as I pointed out in #649 (comment), I don't think this patch is necessary at all. Let's continue discussing there.
Confirmed, not needed. Sorry about the noise. Someone needs to fire the person writing test tho :) |
@domenic, I'm still kinda wondering if we should add "property spread" to infra (even if we didn't need it here). Consider, after validation the |
Yeah, I definitely think some kind of "merge-with-overwrite" for ordered maps would be reasonable. I'd prefer to wait until we have a consumer, but we could open a tracking issue perhaps. |
This builds on #668 to allow incremental data updates as proposed in #649.
Preview | Diff