arg attributes in MathML examples in open concept list #67

davidcarlisle · 2024-06-13T21:26:08Z

This adds arg attributes to most MathML examples (and a single test intent attribute) and has some styling using @dginev 's version of the css for arg.

It's work in progress but I'd like to merge anyway to avoid getting too far ahead on a branch, and give time to bring the core list to the same format.

The html/css rendering of the arg attributes is visible by hovering over them at

https://davidcarlisle.github.io/mathml-docs/intent-open-concepts/

dginev · 2024-06-16T13:08:24Z

_data/open.yml

@@ -887,7 +910,7 @@ concepts:
      property: mixfix
      area: "set theory"
      comments:
-       - " $<$ mi>f:X⤖Y"
+       - " $<$ mrow intent='bijection($a1,$a2,$a3)'>>f: arg='a2'>X⤖ arg='a3'


For bijection the example with f was poorly chosen by me - predates properties. It would be f:bijection in a world where is-a property use was still available.

A better example would be an infix arrow, but those are non-standard, math SE discussion. Maybe X ↔ Y with the ↔ marked as intent="bijection", maybe not.

Not sure why you say infix arrows are non standard, all the arrows are infix binary by default. Oh you mean people on that SE thread don't agree on which arrows to use, not that arrows being infix are non standard, OK.

But yes, in general lots of the examples will need to be reviewed there are several I've spotted while doing this round that I plan to raise issues on after the merge.

But I'm trying to keep this PR just on the format so replacing notation: field with mathml hints to actual mathml. Current status is 1258 elements and 248 notation[a-z]: fields so it's getting there... But if someone (hint) would approve the merge I could merge this bulk edit to w3c, and then individual issues and/or PR could be raised on problematic examples. As it is, editing the w3c copy will lead to merge conflicts and only I have edit writes on my fork so I really would rather forks are short lived.

The bijection change was made in this PR, hence I reviewed it here. If anything, I have been trying to keep my comments to a helpful minimum. I will pass my review flag to Moritz @physikerwelt who - if interested - may help resolve the PR. I am not comfortable doing much more here.

as you wish, I wouldn't have said it's a change here Ijust added mathml if we decide to treat this as a property rather than a concept the whole row would presumably go, but that's fine: there will neeed to be several such edits whatever format the notation is shown. mathml with or without intent attributes.

My comments:

Can we have intent attributes on the mathml root element, that way we would not need to add an mrow?

I think the overall pattern a1-9 is good.

Can I check the result of this PR somewhere visually?

@physikerwelt we could have intent om math but I added the mrow as if you ever want to copy these fragments into a larger expression you would have to have mrows, so it seemed simpler to add them even though it does add one extra layer in these small examples. Yes the fork is rendering at https://davidcarlisle.github.io/mathml-docs/intent-open-concepts/ including the button to show mathml source. (Currently you need to refresh the page to get back to the initial state)

Thank you. This looks good. Two minor issues:

Invalid markup: Incorrect number of children for tag.

“mathvariant='bold'” on MathML elements is deprecated and will be removed at a future date.

Thank you Moritz for the time reviewing the PR. I would suggest to David to tag Moritz directly in future PRs as the outcomes appear more productive.

intent-open-concepts/index.md

physikerwelt · 2024-06-17T13:35:24Z

_data/open.yml

@@ -8019,7 +8216,8 @@ concepts:
      en: multichoose
      property: fenced-stacked
      area: "combinatorics"
-      notation: "mrow ( mfrac $1 $2"
+      comments:
+       - " $(\binom{n}{n})$ "


you could replace the n with 𝐧 (U+1D427 (119847))?

@physikerwelt I seemed to have two n there. I made one an m but would you really use bold upright not just normal math italic? but in general as I commented to Deyan I'd rather reviewing individual entries happens at w3c with more reasonable sized diffs as this PR was really asking about the change in format to add arg= attributes which is nearly completed now just 126 rows with !!F and no real mathml out of 1264 math elements. But diff for this PR is now nearly 5000 lines I want to merge as is, to allow individual entries to be reviewed/edited at w3c (where more people have write access)

physikerwelt · 2024-06-17T13:58:56Z

_data/open.yml

@@ -8217,7 +8217,7 @@ concepts:
      property: fenced-stacked
      area: "combinatorics"
      comments:
-       - " $(\binom{n}{n})$ "
+       - " $(\binom{m}{n})$ "


I see that a lot of lines were changed. However this is the only line that causes a warning in Firefox. Thus I was thinking it would be good to come from 1 to 0 warning. I have no particular feeling about the unicode character.

@physikerwelt ah sorry yes the warning is the mathvariant bold which isn't actually valid i added it as unicode doesn't have bold brackets I;'ll replace bycss. Firefox also tells me Invalid markup: Incorrect number of children for tag.` update coming up....

@physikerwelt thanks, fixed

physikerwelt

I am happy if this is merged. However, I think it would be better if we could fix the warnings generated in the browser console.

davidcarlisle · 2024-06-17T14:29:11Z

I am happy if this is merged. However, I think it would be better if we could fix the warnings generated in the browser console.

yes sorry about that firefox console is now clean

* arg attributes * force inline display (subscript alignment) of hover tooltips * highlight arg slots even on no hover * some arity 3 fixes * speech for therefore * triangle number * well formed mathml * well formed mathml * mismatched parens in ultrapower * agr1 n cases * missing quotes in yaml * arity 2 matrix * add intent attributes * flag missing intent in red * more intents * more intents * more intents arity 4 * more intents * more intents * mismatched brackets * mismatched quote * dihedral group * direct-limit * more mathml * faber polynomial * field of sets * hypertorus * hypertorus * nth ... * bijection arguments * cap product * spurious } in css #496 * arity 0 notations * arity 3 notations * arity 2 Work in Progress * arity 1 Work in Progress * no a2 in arity 1 stubs * use star not n for n-ary to match core list * more mathml * double >> * /mrow * stalk * stalk extra mrow * surjection speech template * derivation * legendre poly * col vector * conditional-xxx * mathml * a9 * msup cases * missing arg attributes * missing arg attributes * showmath * preserve * mfrac cases * yaml fixes * wittaker 2 and 3 * wittaker W * wittaker missing ) * wl mean * wl mean * avoid named entities * typo * msub cases * more mathml * more mathml * more mathml * yaml fixes * pqr not prr * rising/falling factorial * mtable cases * mtable cases * m n not n n * valid mathml

arg attributes

a7406f0

davidcarlisle self-assigned this Jun 13, 2024

davidcarlisle requested review from dginev and NSoiffer June 13, 2024 21:56

davidcarlisle added 26 commits June 14, 2024 11:44

force inline display (subscript alignment) of hover tooltips

5c4ae3e

highlight arg slots even on no hover

6f1b02c

some arity 3 fixes

5ed8a71

speech for therefore

b1cadf1

triangle number

2e144cf

well formed mathml

157527d

well formed mathml

5810ca3

mismatched parens in ultrapower

582d1fb

agr1 n cases

c5856b5

missing quotes in yaml

2d2f789

arity 2 matrix

4d79579

add intent attributes

6ff60e1

flag missing intent in red

1f37f41

more intents

b76cffd

more intents

20a7e1e

more intents arity 4

7b699d1

more intents

36b0688

more intents

e72c24b

mismatched brackets

64341cf

mismatched quote

89ebb63

dihedral group

0b76d0a

direct-limit

ccda606

more mathml

20d4d2f

faber polynomial

5f175dd

field of sets

cfdff81

hypertorus

1d263f3

davidcarlisle added 8 commits June 16, 2024 11:17

preserve

60e5d3b

mfrac cases

40545ba

yaml fixes

c562ecb

wittaker 2 and 3

a02bee9

wittaker W

5271d79

wittaker missing )

0d357d5

wl mean

98d49fc

wl mean

a2fb89e

dginev reviewed Jun 16, 2024

View reviewed changes

davidcarlisle added 11 commits June 16, 2024 19:31

avoid named entities

fa3b3cb

typo

b8ef673

msub cases

b730e38

more mathml

71796fc

more mathml

0ea8d64

more mathml

774973e

yaml fixes

fad1573

pqr not prr

a78f274

rising/falling factorial

07d8a71

mtable cases

da935fc

mtable cases

66e2376

dginev requested a review from physikerwelt June 17, 2024 11:34

physikerwelt reviewed Jun 17, 2024

View reviewed changes

intent-open-concepts/index.md Show resolved Hide resolved

physikerwelt reviewed Jun 17, 2024

View reviewed changes

m n not n n

131a301

physikerwelt reviewed Jun 17, 2024

View reviewed changes

physikerwelt approved these changes Jun 17, 2024

View reviewed changes

valid mathml

52dafb1

davidcarlisle merged commit fe73b8d into w3c:main Jun 17, 2024

arg attributes in MathML examples in open concept list #67

arg attributes in MathML examples in open concept list #67

Uh oh!

Conversation

davidcarlisle commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidcarlisle Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidcarlisle Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

physikerwelt Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

physikerwelt left a comment

Choose a reason for hiding this comment

Uh oh!

davidcarlisle commented Jun 17, 2024

Uh oh!

Uh oh!

davidcarlisle commented Jun 13, 2024 •

edited

Loading

davidcarlisle Jun 17, 2024 •

edited

Loading

davidcarlisle Jun 17, 2024 •

edited

Loading

physikerwelt Jun 17, 2024 •

edited

Loading