-
Notifications
You must be signed in to change notification settings - Fork 27
Define concept of minimum role #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Worked on this with @aleventhal as this concept is necessary for some current HTML features (as identified in the attribute mapping table in this PR) as well as future proposed features, such as `popover`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no feedback of substance 😅, just a couple proofing suggestions.
Co-authored-by: Adam Page
Co-authored-by: Adam Page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an approval caveat remove the sentence fragment, at least!
Maybe it's time to open issues on the browsers with this change? |
needed to call out that an explicit role of none, presentation or generic would still need to result in that role being ignored if other conditions were true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few problems with this and suggest we schedule a deep dive.
The first is that this doesn't seem to account for native-reserved roles, or roles that we can't yet or haven't yet mimicked with ARIA. For example, or
… I think this change suggests UAs MUST map both to
group
, even though it wouldn't be logical to do so. Even if ARIA eventually adds a role for native date pickers, video
is likely to remain separate for a while, because there isn't a good method to support the video API that goes along with it.
The second issue is that ARIA's concept of group requires a much more explicit and purposeful author decision, IMHO, than the related concept in the AX API... As a reminder, Update b/c I thought of another one. Does the sub-span in this one really need a minimum role?AXGroup
predates ARIA's group
by almost a decade, and is used as a generic container. ARIA's group
, as I understand it, represents some explicit logical grouping, so I am not certain it's a good change to force promotion of something like <main aria-label="Edit post">
<div contenteditable>
Now I have an extraneous, unlabeled group inside my main, where I hadn't before.
div>
main>
<main contenteditable="true">
Obi-Wan never told you what happened to your father.
He told me enough! He told me you killed him!
<span contenteditable="false">No. I am your father.span>
div>
@cookiecrook thank you for the review. per your two comments:
it was definitely the intent to account for that, so happy to incorporate changes to make sure that's included / I'll have a think on other wording to make sure that's clear. re:
|
FYI Our comments crossed when I added a third to the list: |
@cookiecrook we had talked about |
Co-authored-by: James Craig
Co-authored-by: Valerie Young
adds "not mapped" to the ARIA role cell. there is no perfect role for this right now, and until one is made (if ever) we shouldnt' change this.
We had a deep dive this morning, it seems the main conclusions were:
|
Also that term had been used to describe the fallback roles such as |
had a call with aaron and james today i need to work though if this should be merged, or can be revised into contextual role. i'll work on that soon |
As a new concept called minimum role was added to the HTML-AAM spec[1], and the contents corresponding to global attributes in that spec have been implemented. [1]: w3c/html-aam#454 AX-Relnotes: n/a. Fixed: 1474047 Change-Id: I586506e8ddd1e81ad11e92ef9e167586cb41545e
@scottaohara what's the update on this? Which attributes should we start with? |
OK, finally got back to this and resolved all the merge conflicts. The PR is much simpler to review now in the diff mode. This now adds the minimum role concept, and to start we're indicating this will occur for the
I plan on some editorial revising of this section with the contextual role PR (#484) - but need this to merge first before I work on that anymore. I think this finalizes the outstanding conversations for this PR (with any potential addition of tabindex being it's own topic for the future) |
Still LGTM. |
+1! |
add tests for minimum role in html aam w3c/html-aam#454
merged via w3c/aria#2220 |
Bug: w3c/html-aam#454 Change-Id: Ia3930b068311f26f6a7e0be8bbcce53acf820bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5663675 Auto-Submit: Aaron LeventhalCommit-Queue: Mark Schillaci Commit-Queue: Aaron Leventhal Reviewed-by: Mark Schillaci Cr-Commit-Position: refs/heads/main@{#1320576}
* Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link
Automatic update from web-platform-tests Create roles-minimum.tentative.html (#44934) * Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link -- wpt-commits: eba641bdc0a4b66b0bb162ebd775e46bab2b5ca4 wpt-pr: 44934 Differential Revision: https://phabricator.services.mozilla.com/D250952
Automatic update from web-platform-tests Create roles-minimum.tentative.html (#44934) * Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link -- wpt-commits: eba641bdc0a4b66b0bb162ebd775e46bab2b5ca4 wpt-pr: 44934 Differential Revision: https://phabricator.services.mozilla.com/D250952
Automatic update from web-platform-tests Create roles-minimum.tentative.html (#44934) * Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link -- wpt-commits: eba641bdc0a4b66b0bb162ebd775e46bab2b5ca4 wpt-pr: 44934 Differential Revision: https://phabricator.services.mozilla.com/D250952
Automatic update from web-platform-tests Create roles-minimum.tentative.html (#44934) * Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link -- wpt-commits: eba641bdc0a4b66b0bb162ebd775e46bab2b5ca4 wpt-pr: 44934 Differential Revision: https://phabricator.services.mozilla.com/D250952 UltraBlame original commit: 157047121bca597e3c6232f62942306071927820
Automatic update from web-platform-tests Create roles-minimum.tentative.html (#44934) * Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link -- wpt-commits: eba641bdc0a4b66b0bb162ebd775e46bab2b5ca4 wpt-pr: 44934 Differential Revision: https://phabricator.services.mozilla.com/D250952 UltraBlame original commit: 157047121bca597e3c6232f62942306071927820
Automatic update from web-platform-tests Create roles-minimum.tentative.html (#44934) * Create roles-minimum.tentative.html * add tests for minimum role in html aam w3c/html-aam#454 * remove unused call * link to issue to clarify dead spec link -- wpt-commits: eba641bdc0a4b66b0bb162ebd775e46bab2b5ca4 wpt-pr: 44934 Differential Revision: https://phabricator.services.mozilla.com/D250952 UltraBlame original commit: 157047121bca597e3c6232f62942306071927820
Worked on this with @aleventhal as this concept is necessary for some current HTML features (as identified in the attribute mapping table in this PR) as well as future proposed features, such as
popover
.Implementation
Preview | Diff