[css-overflow-4] Draft spec for `continue: collapse` (#7708) #10816

andreubotella · 2024-09-02T11:59:52Z

No description provided.

bfgeek · 2024-09-17T16:26:07Z

@emilio - Does this look reasonable to you?

andreubotella · 2024-10-03T23:38:55Z

Before now, this PR allowed clamping between any two blocks, to make it closer to the continue: discard behavior, but in hallway conversations in TPAC we agreed that having it clamp to the last line before clamp, even if there are lineless boxes after it that will still fit, was a better behavior. I just updated the spec text to reflect this.

tabatkins · 2024-10-04T17:51:41Z

but in hallway conversations in TPAC we agreed that having it clamp to the last line before clamp, even if there are lineless boxes after it that will still fit, was a better behavior

In particular, the argument was that auto clamping should be equivalent to the largest clamp that avoids overflow; it's weird if auto actually lets you include an amount of content between two values, and thus can't be reproduced directly.

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791226 gecko-commit: c6ce92301ca11292a5dd25f07a80243592c94e5a gecko-reviewers: layout-reviewers, dshin

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791226 gecko-commit: cf9f54eef33465d089f850a55da5734a911fdac4 gecko-reviewers: layout-reviewers, dshin

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791226 gecko-commit: cf9f54eef33465d089f850a55da5734a911fdac4 gecko-reviewers: layout-reviewers, dshin

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 UltraBlame original commit: c6ce92301ca11292a5dd25f07a80243592c94e5a

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 UltraBlame original commit: cf9f54eef33465d089f850a55da5734a911fdac4

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 UltraBlame original commit: c6ce92301ca11292a5dd25f07a80243592c94e5a

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 UltraBlame original commit: cf9f54eef33465d089f850a55da5734a911fdac4

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 UltraBlame original commit: c6ce92301ca11292a5dd25f07a80243592c94e5a

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578 UltraBlame original commit: cf9f54eef33465d089f850a55da5734a911fdac4

This matches the proposal in w3c/csswg-drafts#10816, and creates much better behavior. Differential Revision: https://phabricator.services.mozilla.com/D157578

frivoal

This seems mostly good. I've made a few small suggestion for normative changes, and more suggestions for editorial changes (most of which are about source formatting).

Most of the remaining issues are orthogonal to this PR, so I think we can merge first and keep working on those later, as soon as the comments on this PR are addressed.

css-overflow-4/Overview.bs

frivoal · 2024-11-04T07:39:13Z

@tabatkins , for your comment in #10816 (comment), I'd suggest following up in #10868, because that aspect exists before this PR. The text of the spec may need to change depending on where we land on that issue (and others), but this PR isn't changing it, so I think we should take one problem at a time.

Co-authored-by: Florian Rivoal

tabatkins

LGTM after an example or explanation of the one case I called out.

css-overflow-4/Overview.bs

tabatkins · 2025-05-23T22:33:21Z

css-overflow-4/Overview.bs

+	is not greater than the [=block size=] the box would have
+	if its automatic block size were infinite;
+	or if that is not the case for any possible clamp points,
+	to the first possible clamp point in the block formatting context.


This could use an example of what the "Otherwise" behavior is trying to guard against.

It's not guarding against anything. In this PR, currently, line-clamp: 3 will set max-lines: 3, and that will clamp based on the number of lines; while line-clamp: auto will set max-lines: none, which will clamp based on the height. (I opened #12041 to discuss this, though.) This height-based clamping is what the entire "otherwise" clause describes.

I will definitely have to do some rewriting and clarification, though, because this is clearly not obvious on first glance.

css-overflow-4/Overview.bs

andreubotella · 2025-05-23T23:24:39Z

I just noticed that @syncbot for some reason got rid of three commits I made updating this PR to match the April F2F resolutions. I've just cherry-picked them.

@tabatkins, would you mind reviewing those again?

andreubotella added the css-overflow-4 label Sep 2, 2024

andreubotella requested review from frivoal and emilio September 2, 2024 11:59

bfgeek mentioned this pull request Sep 18, 2024

Unprefixed line-clamp web-platform-tests/interop#725

Closed

andreubotella mentioned this pull request Sep 19, 2024

[css-overflow] Is continue: discard working in the fragment tree useful? #7708

Closed

andreubotella added 3 commits October 4, 2024 08:40

[css-overflow-4] Draft spec for continue: collapse (#7708)

c2fa930

Clarification about float clearance in the automatic block size

c7df9c9

Update to only allow clamping after a line

1699d89

andreubotella force-pushed the continue-collapse branch from b3b73b4 to 1699d89 Compare October 3, 2024 23:40

andreubotella mentioned this pull request Oct 11, 2024

[css-overflow] Invisible line boxes and line-clamp #11021

Closed

moz-wptsync-bot mentioned this pull request Oct 21, 2024

[Gecko Bug 1791226] Don't paint line-clamped lines. web-platform-tests/wpt#48729

Merged

frivoal requested changes Nov 4, 2024

View reviewed changes

frivoal mentioned this pull request Nov 4, 2024

[css-overflow] Add spec text for the continue variant of line-clamp #10322

Closed

andreubotella and others added 2 commits December 3, 2024 10:10

Apply suggestions from code review

ee8fab9

Co-authored-by: Florian Rivoal

Update css-overflow-4/Overview.bs

178c050

Co-authored-by: Florian Rivoal

andreubotella mentioned this pull request Dec 16, 2024

[css-overflow] Web compat issue when hiding abspos after the line-clamp point #11379

Open

andreubotella mentioned this pull request Mar 19, 2025

[css-overflow-4] Should abspos painting in line-clamp depend only on whether the containing block is before clamp? #11962

Open

andreubotella force-pushed the continue-collapse branch from 178c050 to 0213411 Compare April 22, 2025 15:44

andreubotella requested a review from frivoal April 30, 2025 14:27

syncbot force-pushed the continue-collapse branch from ff80489 to 178c050 Compare May 2, 2025 01:24

tabatkins approved these changes May 23, 2025

View reviewed changes

tabatkins and others added 8 commits May 23, 2025 15:37

Update css-overflow-4/Overview.bs

c9aadd3

Update css-overflow-4/Overview.bs

ce29a7a

Update css-overflow-4/Overview.bs

716ddfc

Update css-overflow-4/Overview.bs

0db0a52

Update css-overflow-4/Overview.bs

e5b5c69

Update for #10439

6398998

Update for #11962

94503b3

Update for #10868

cb6491a

tabatkins approved these changes May 29, 2025

View reviewed changes

tabatkins merged commit ab4d234 into main Jun 3, 2025
1 check passed

andreubotella deleted the continue-collapse branch June 9, 2025 11:21

[css-overflow-4] Draft spec for continue: collapse (#7708) #10816

[css-overflow-4] Draft spec for continue: collapse (#7708) #10816

Uh oh!

Conversation

andreubotella commented Sep 2, 2024

Uh oh!

bfgeek commented Sep 17, 2024

Uh oh!

andreubotella commented Oct 3, 2024

Uh oh!

tabatkins commented Oct 4, 2024

Uh oh!

frivoal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frivoal commented Nov 4, 2024

Uh oh!

tabatkins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tabatkins May 23, 2025

Choose a reason for hiding this comment

Uh oh!

andreubotella May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andreubotella commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[css-overflow-4] Draft spec for `continue: collapse` (#7708) #10816

[css-overflow-4] Draft spec for `continue: collapse` (#7708) #10816

andreubotella May 23, 2025 •

edited

Loading

andreubotella commented May 23, 2025 •

edited

Loading