-
Notifications
You must be signed in to change notification settings - Fork 719
[css-pseudo] highlight pseudos and compat stroke/fill properties #7580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054}
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Dec 11, 2022
…erties valid_for_highlight, a=testonly Automatic update from web-platform-tests HighlightInheritance: compat stroke properties valid_for_highlight ‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054} -- wpt-commits: 204eae05514325f7949f48638237da3eb03c19b1 wpt-pr: 37270
BruceDai
pushed a commit
to BruceDai/wpt
that referenced
this issue
Dec 13, 2022
‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Dec 14, 2022
…erties valid_for_highlight, a=testonly Automatic update from web-platform-tests HighlightInheritance: compat stroke properties valid_for_highlight ‘-webkit-text-fill-color’ is valid_for_highlight, but we forgot to mark ‘-webkit-text-stroke-color’ and ‘-webkit-text-stroke-width’ as valid_for_highlight too. They are only valid_for_highlight_legacy at the moment. Whether all three should be applicable is pending a spec issue [1], but HighlightInheritance is not stable yet anyway, and enabling them in this patch unblocks bumping HighlightInheritance to experimental. [1] w3c/csswg-drafts#7580 Bug: 1024156 Change-Id: Ifcd121800ffe9d0cae0b7984f98cf9bf1c83f002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060396 Reviewed-by: Anders Hartvoll RuudCommit-Queue: Delan Azabani Cr-Commit-Position: refs/heads/main@{#1078054} -- wpt-commits: 204eae05514325f7949f48638237da3eb03c19b1 wpt-pr: 37270
The CSS Working Group just discussed
The full IRC log of that discussion |
This needs a clarifying note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://drafts.csswg.org/css-pseudo-4/#highlight-styling
‘-webkit-text-fill-color’, ‘-webkit-text-stroke-color’, ‘-webkit-text-stroke-width’, and ‘-webkit-text-stroke’ are unrelated to those SVG-only properties, but they work roughly the same way and are supported interoperably. WPT even has a test for ::selection with ‘-webkit-text-fill-color’. Should we make these properties applicable to highlights?
(@fantasai, @frivoal, @mrego)
The text was updated successfully, but these errors were encountered: