Skip to content

[css-shapes-1] Updated CR of CSS Shapes? #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svgeesus opened this issue Jul 14, 2021 · 19 comments
Open

[css-shapes-1] Updated CR of CSS Shapes? #6450

svgeesus opened this issue Jul 14, 2021 · 19 comments
Labels
Administrative Tracker For external review / publication tracking issues. Agenda+ css-shapes-1 Current Work

Comments

@svgeesus
Copy link
Contributor

The ED dates to 20 May 2021 and lists substantive changes since the previous CR of 2014. (commit history)

Time for an updated CR?

@svgeesus svgeesus added css-shapes-1 Current Work Administrative Tracker For external review / publication tracking issues. labels Jul 14, 2021
@svgeesus
Copy link
Contributor Author

@atanassov @astearns

@svgeesus
Copy link
Contributor Author

svgeesus commented Dec 6, 2021

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 2, 2022

The wpt implementation report is more comprehensive.

@svgeesus
Copy link
Contributor Author

svgeesus commented Nov 3, 2022

So, this 2014 CR is badly in need of republication. There have been a bunch of edits and the changes section is not up to date. The Security/Privacy section needs to be split in two.

Ideally markup should be added to indicate tested sections, but that work should not hold up republication.

I suggest publishing a CR Draft, then doing horizontal review, followed by CR Snapshot.

@svgeesus
Copy link
Contributor Author

svgeesus commented Nov 9, 2022

I went through the commit history (including the commit history before it was renamed and when it used the pre-bikeshed .src format), checking all commits against the changes section and adding any that had been missed. The changes section is now complete.

I also split Privacy and Security considerations into two, as required for horizontal review, and added a link to the implementation report

There is one linking error, because the old production is used but it no longer exists. But that is an easy fix. Apart from that, this spec looks in good shape for CR Draft.

@svgeesus
Copy link
Contributor Author

svgeesus commented Nov 9, 2022

There is one linking error, because the old production is used but it no longer exists. But that is an easy fix.

Fixed

@svgeesus
Copy link
Contributor Author

svgeesus commented Nov 9, 2022

@astearns
Copy link
Member

astearns commented Nov 9, 2022

Meeting notes since the bot missed them

RESOLVED: Publish css-shapes-1 CRD

 Topic: [css-shapes-1] Updated CR of CSS Shapes? Administrative Tracker For external review / publication tracking issues
 q+
 chris: I'm whining about this thing not being published since 2014
 chris: I went through all the commits since 2014 and updated the Changes list
 chris: added implementation, split privsec section
 chris: I think this is ready to go
<•astearns> q+
 astearns: Thanks so much for doing that work
 astearns: My preference would have been to get the edits for reconciling with gradient syntax first, but since you've done this work, I'm happy to publish now and republish later with the edits
 chris: sounds good to me
 chris: If you thought those edits would be timely that would be fine, but if you think it'll confuse people
 astearns: No, I am now good for publishing and I can't guarantee that my edits will be timely
 Rossen_: +1, thanks for the help chris this is great
 Rossen_: objections to publish CRD?
 RESOLVED: Publish css-shapes-1 CRD
 Rossen_: again, thanks Chris, for doing the work

@svgeesus
Copy link
Contributor Author

svgeesus commented Nov 9, 2022

The CSS Working Group just discussed [css-shapes-1] Updated CR of CSS Shapes?.

The full IRC log of that discussion chris: I'm whining about this thing not being published since 2014
chris: I went through all the commits since 2014 and updated the Changes list
chris: added implementation, split privsec section
chris: I think this is ready to go
<@astearns> q+
* Zakim sees chris, astearns on the speaker queue
* fantasai ack chris
* Zakim sees astearns on the speaker queue
ack chris
* fantasai ack astearns
* Zakim sees astearns on the speaker queue
* Zakim sees no one on the speaker queue
ack astearns
* Zakim sees no one on the speaker queue
astearns: Thanks so much for doing that work
astearns: My preference would be to get the edits for reconciling with gradient syntax first, but since you've done this work, I'm happy to publish now and republish later with the edits
chris: sounds good to me
chris: If you thought those edits would be timely that would be fine, but if you think it'll confuse people
astearns: No, I am now good for publishing and I can't guarantee that my edits will be timely
Rossen_: +1, thanks for the help chris this is great
Rossen_: objections to publish CRD?
RESOLVED: Publish css-shapes-1 CRD
Rossen_: again, thanks Chris, for doing the work

RESOLVED: Publish css-shapes-1 CRD

@svgeesus
Copy link
Contributor Author

Publication request sent 10 Nov 2022, expected publication Tues 15 Nov 2022

@svgeesus
Copy link
Contributor Author

CRD Published 15 Nov

@svgeesus svgeesus reopened this Jun 4, 2025
@svgeesus
Copy link
Contributor Author

svgeesus commented Jun 4, 2025

@astearns @atanassov @noamr I updated the changes section to date. I also added WPT annotations. So it is in better shape for republication as CRD once the backporting from css-shapes-2 is done.

@svgeesus
Copy link
Contributor Author

svgeesus commented Jun 4, 2025

The CSS Working Group just discussed FPWD of css-shapes-2 or porting shape() to css-shapes-1, and agreed to the following:

  • RESOLVED: Move shape() to css-shapes-1 and ask for wide review on that and maybe path() and add noamr as editor to css-shapes-1
The full IRC log of that discussion Topic: FPWD of css-shapes-2 or porting shape() to css-shapes-1
github: https://github.com//issues/6900#issuecomment-2930919526
noamr: Time for a WD that includes the shape() function
noamr: There are other things in shapes-2 that are not ready for WD, so proposal is to move shape() to css-shapes-1 and publish a WD of that
scribe+ kbabbitt
noamr: Then it can live happily with the rest of the basic shapes
fantasai: seems reasonable
... shapes 1 is currently CR
... by moving it in maybe it will get published
... probably want to publish WD in ?? review
... try to move it back into CR
ChrisL: want to drop from CR?
fantasai: adding new feature, seems appropriate
astearns: Didn't drop for path()
astearns: but either way is fine by me
ChrisL: dropping the whole draft to WD is a signal we don't want to send, but it is a new feature
astearns: can we put the feature in and ask for wide review just the new feature?
ChrisL: would be fine
fantasai: I think we can do that
astearns: Move shape() to css-shapes-1 and when ready ask for wide review on that and maybe path()
astearns: any objections?
RESOLVED: Move shape() to css-shapes-1 and ask for wide review on that and maybe path() and add noamr as editor to css-shapes-1

@svgeesus
Copy link
Contributor Author

svgeesus commented Jun 5, 2025

@noamr I see Move shape() to css-shapes-1 and that you are added as co-editor, so re-adding Agenda+ to get a resolution to publish CR Draft.

@noamr
Copy link
Collaborator

noamr commented Jun 5, 2025

@noamr I see Move shape() to css-shapes-1 and that you are added as co-editor, so re-adding Agenda+ to get a resolution to publish CR Draft.

Thanks! I'm having issues with publishing the WD via echidna, getting "The document could not be published: Not Implemented". Is that a known issue I can resolve somehow?

@svgeesus
Copy link
Contributor Author

svgeesus commented Jun 5, 2025

'm having issues with publishing the WD via echidna,

As expected, it needs a WG resolution @astearns and then manual publishing (which I am happy to do)

@svgeesus
Copy link
Contributor Author

svgeesus commented Jun 5, 2025

Meanwhile you should update changes to add "Moved shape() from css-shapes-2 to css-shapes-1"

@noamr
Copy link
Collaborator

noamr commented Jun 5, 2025

Meanwhile you should update changes to add "Moved shape() from css-shapes-2 to css-shapes-1"

I've done that already

@svgeesus
Copy link
Contributor Author

svgeesus commented Jun 5, 2025

Aha. The list is in most-recent order, while you added it at the end so I didn't see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administrative Tracker For external review / publication tracking issues. Agenda+ css-shapes-1 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants