Skip to content

[css-color-5] Consider making colorspace required for color-adjust() #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weinig opened this issue Mar 25, 2021 · 1 comment
Closed

[css-color-5] Consider making colorspace required for color-adjust() #6141

weinig opened this issue Mar 25, 2021 · 1 comment

Comments

@weinig
Copy link
Contributor

weinig commented Mar 25, 2021

Much like colorspace is now required for color-mix() (see #6051), I think the colorspace should be required for color-adjust(). Repeating what I stated in the previous issue:

I would like to suggest we remove the default value and always require a colorspace to specified. In general, I think requiring explicit color spaces is beneficial to avoid circumstances like we have now with implicit sRGB, where the best choice is no longer what we think it is. If in the past, we had required all colors / transformations of colors to be tagged, it would be much easier to change things today, as finding all the uses of sRGB in a codebase would be just searching for that explicit usage.

It's always possible to add a default later, if it becomes a burden, but it is much harder to remove one, so I think being conservative for now is the right tradeoff to make.

When doing this, we should also consider moving it to the beginning to match color-mix(), which is captured in #6053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants