-
Notifications
You must be signed in to change notification settings - Fork 719
[css-color-adjust-1] Combine forced-color-adjust and color-adjust properties somehow? #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In terms of the cascade, the questions (and my best guesses for answers) are:
Initial syntax for a combined
The other keywords combine with
The list of specific situations could be extended in the future, which is why I also allowed This arrangement is a little different from most CSS properties, because we want the default to be to allow everything, and we want authors to carefully think about which values they are disabling. The downside is that authors might just use |
I'm inclined to think that these are separate things that should stay in separate properties. I think the risk of combining them is that some pages whose authors have carefully considered how printing should work will work badly for users with accessibility needs related to color contrast, and pages whose authors have carefully considered how they should work for users who require high color contrast will waste a lot of ink when printed. |
@dbaron Yeah, we'd need to express the values in a way that trying to turn off a specific type of adjustment doesn't turn off all of them. |
The CSS Working Group just discussed The full IRC log of that discussion |
Coming here from the TAG review for css-color-adjust-1. We are also curious about the reasoning behind not combining these two. I see @dbaron's comments above, but I think more investigation is warranted as to whether the mitigations in each scenario are similar enough that they're not worth keeping separate, only to end up duplicating styles or failing to handle one or other scenario. |
The CSS Working Group just discussed
The full IRC log of that discussion |
Err, was going to close mozilla/wg-decisions#515 (though this one should probably be closed as well) |
@alice We're closing this as no change because we don't have a good idea for how to do this in a way that doesn't introduce problems. Considerations are:
There's one use case where pretty much any imagineable color adjustment (the ones that exist, and ones we might invent in the future) should be turned off: color swatches. It would be nice if there was some way to indicate this without encouraging authors to overuse it. But overall it seems like pages are more likely to make errors if we cascade these two switches as a single property than if they are separate. :( |
I just looked at the Almanac 2020 data, and
What about making |
Note that 0.25% is far above our threshold for potential breakage. That's an enormous number of pages. |
@LeaVerou It's not just about getting backgrounds to print: UAs do automatic adjustment for e.g. light on dark pages to flip their colors so they'll print readably without using all the ink. That said, I wonder if we should add |
Agenda+, specifically, to discuss the option of moving the name to |
The CSS Working Group just discussed
The full IRC log of that discussion |
…nt-color-adjust'; re-add 'color-adjust' as alias (shorthand). #3880
The
forced-color-adjust
andcolor-adjust
properties are both switches for opting out of a form of forced color modification. Is there an ergonomic way (in terms of the cascade) to combine them?The text was updated successfully, but these errors were encountered: