Skip to content

[pointer-animations] Minor syntax suggestions #12285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdoublev opened this issue Jun 5, 2025 · 3 comments
Closed

[pointer-animations] Minor syntax suggestions #12285

cdoublev opened this issue Jun 5, 2025 · 3 comments
Labels

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Jun 5, 2025

is already defined in Scroll Animations, which is a problem for CSS tools like w3c/webref and its users (like MDN). Not sure what is the best solution. Perhaps it could be defined in CSS Logical. At worst, it should be defined only once.

expands to the same keywords than in Scroll Animations. Besides, "source" seems a bit general, which could prevent using this production name with other values in other contexts. Perhaps both could be replaced with or whatever production name would be appropriate?

@cdoublev cdoublev added the pointer-animations-1 Current Work label Jun 5, 2025
@AtkinsSJ
Copy link
Contributor

AtkinsSJ commented Jun 5, 2025

I noticed this is already partly addressed in #12283. cc @tidoust

@ydaniv
Copy link
Contributor

ydaniv commented Jun 5, 2025

Thanks @cdoublev! I approved #12283 which addresses both.
Ideally could probably be reused for both SDA and PDA.
And should be prefixed, like in the PR above.

@cdoublev
Copy link
Collaborator Author

cdoublev commented Jun 6, 2025

Alright. The main issue was the duplication of definitions. So closing as fixed by #12283 then.

Two other suggestions though...

could be used in the value definition of *-timeline-axis.

animation-range-center is defined with below its definition table. I guess it should be , like in the definition table.

@cdoublev cdoublev closed this as completed Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants