CLDR-18615 Detect page from xpath if obsolete page name is used #4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Extend the existing usage of page=auto to handle obsolete/invalid page names -On the front end, always include xpstrid in the page request, if available -On the back end, do not reject the combination of page and xpstrid; instead use xpstrid as a fallback to determine the page -New PageId.fromString is the same as PageId.forString, except it returns null instead of throwing ICUException; PageId.forString still has other callers; changing them seems risky and out of scope for this PR, except for WebContext.getPageId -Fix some compiler warnings -Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Extend the existing usage of page=auto to handle obsolete/invalid page names
-On the front end, always include xpstrid in the page request, if available
-On the back end, do not reject the combination of page and xpstrid; instead use xpstrid as a fallback to determine the page
-New PageId.fromString is the same as PageId.forString, except it returns null instead of throwing ICUException; PageId.forString still has other callers; changing them seems risky and out of scope for this PR, except for WebContext.getPageId
-Fix some compiler warnings
-Comments
CLDR-18615
ALLOW_MANY_COMMITS=true