Skip to content

CLDR-18561 hora peninsular #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertbastian
Copy link
Member

CLDR-18561

  • This PR completes the ticket.

Adds "hora peninsular" to es, es_ES (Spain), es_EA (Ceuta & Melilla), es_IC (Canaries).

ALLOW_MANY_COMMITS=true

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/es_419.xml is different
  • common/main/es.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/es_GQ.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently Spain has daylight savings. I think we might need 3 strings for that in ICU. @richgillam ?

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked it up, and if the caller asks for z, and there is no standard/daylight time, they will get a name based on Madrid or Spain, combined with the daylight/standard strings. So I guess we are ok.

España

horario de verano de {0}
horario estándar de {0}

@robertbastian
Copy link
Member Author

We could add "hora de verano peninsular" and "hora estándar peninsular", the ticket just only asked for "hora peninsular".

Also, there seems to be inconsistent usage of "hora" vs "horario", most metazone names use "hora", some use "horario", the specific region formats use "horario", but the generic one uses "hora".

@AEApple
Copy link
Contributor

AEApple commented Jun 3, 2025

We could add "hora de verano peninsular" and "hora estándar peninsular", the ticket just only asked for "hora peninsular".

Also, there seems to be inconsistent usage of "hora" vs "horario", most metazone names use "hora", some use "horario", the specific region formats use "horario", but the generic one uses "hora".

  • We probably should add for daylight and standard since those will be shorter than the automatically generated ones. I think they're not really using them which is why they aren't requesting them.
  • Should we ask the vetters for feedback on the inconsistency?

@robertbastian
Copy link
Member Author

Should we ask the vetters for feedback on the inconsistency?

Yes!

@robertbastian
Copy link
Member Author

We should also ask vetters whether to use "hora de verano peninsular" or "hora peninsular de verano" (and same for standard).

@macchiati
Copy link
Member

Looks like we can merge. Robert, do you have permissions for that?

@robertbastian
Copy link
Member Author

Do we want to finish the discussion first?

@macchiati
Copy link
Member

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants