-
Notifications
You must be signed in to change notification settings - Fork 398
CLDR-18561 hora peninsular #4738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently Spain has daylight savings. I think we might need 3 strings for that in ICU. @richgillam ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked it up, and if the caller asks for z, and there is no standard/daylight time, they will get a name based on Madrid or Spain, combined with the daylight/standard strings. So I guess we are ok.
España
horario de verano de {0}
horario estándar de {0}
We could add "hora de verano peninsular" and "hora estándar peninsular", the ticket just only asked for "hora peninsular". Also, there seems to be inconsistent usage of "hora" vs "horario", most metazone names use "hora", some use "horario", the specific region formats use "horario", but the generic one uses "hora". |
|
Yes! |
We should also ask vetters whether to use "hora de verano peninsular" or "hora peninsular de verano" (and same for standard). |
Looks like we can merge. Robert, do you have permissions for that? |
Do we want to finish the discussion first? |
sure |
CLDR-18561
Adds "hora peninsular" to es, es_ES (Spain), es_EA (Ceuta & Melilla), es_IC (Canaries).
ALLOW_MANY_COMMITS=true