Skip to content

Commit 1a5027d

Browse files
Kyle HorimotoCommit Bot
Kyle Horimoto
authored and
Commit Bot
committed
[CrOS Tether] Cover all edge cases for BLE connections.
We've seen some recent crashes (e.g., crbug.com/756188) which result from the BluetoothLowEnergyWeaveClientConnection class. I have not been able to track down exactly how this crash is caused, but with this CL, I cover all possible edge cases which could cause a crash and added lots of extra logging which will help us catch this issue. For now, this CL should prevent a crash while we continue to debug. Bug: 756188, 672263 Change-Id: Ibe8f406bd830fb7ed6b7fb21d61be05068e81cea Reviewed-on: https://chromium-review.googlesource.com/634207 Commit-Queue: Kyle Horimoto Reviewed-by: Tim Song Cr-Commit-Position: refs/heads/master@{#497318}
1 parent 24b9cba commit 1a5027d

15 files changed

+539
-681
lines changed

chromeos/components/tether/disconnect_tethering_operation.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,14 @@ void DisconnectTetheringOperation::OnMessageSent(int sequence_number) {
9494
return;
9595

9696
has_sent_message_ = true;
97-
UnregisterDevice(remote_device_);
9897

9998
DCHECK(!disconnect_start_time_.is_null());
10099
UMA_HISTOGRAM_TIMES(
101100
"InstantTethering.Performance.DisconnectTetheringRequestDuration",
102101
clock_->Now() - disconnect_start_time_);
103102
disconnect_start_time_ = base::Time();
103+
104+
UnregisterDevice(remote_device_);
104105
}
105106

106107
void DisconnectTetheringOperation::SetClockForTest(

0 commit comments

Comments
 (0)