b}" hash label key duplicated: "{a: b}" identity hash formatting failure: "{a:}" mixed hash content loss: "{a => b, c: d}" funcall with kwargs gets bogus '=>': "fun(a: b)" "empty #call formatting failure": fun[] "#-@ appended to arg": "-1" empty funcall formatting failure: fun() empty super call formatting failure: super() ternary conditional formatting failure: "a ? b : c" incorrect postfix unless for compound statements: unless a; b; c; end AlternationPatternNode: foo => bar | baz CallOperatorAndWriteNode: foo.bar &&= value CallOperatorOrWriteNode: foo.bar ||= value ClassVariableOperatorAndWriteNode: "@https://github.com/target &&= value" ClassVariableOperatorOrWriteNode: "@https://github.com/target ||= value" ClassVariableOperatorWriteNode: "@https://github.com/target += value" ConstantOperatorAndWriteNode: Target &&= value ConstantOperatorOrWriteNode: Target ||= value ConstantOperatorWriteNode: Target += value ConstantPathOperatorWriteNode: Parent::Child += value ConstantPathOperatorAndWriteNode: Parent::Child &&= value ConstantPathOperatorOrWriteNode: Parent::Child ||= value GlobalVariableOperatorAndWriteNode: $target &&= value GlobalVariableOperatorOrWriteNode: $target ||= value GlobalVariableOperatorWriteNode: $target += value InstanceVariableOperatorAndWriteNode: "https://github.com/target &&= value" InstanceVariableOperatorOrWriteNode: "https://github.com/target ||= value" InstanceVariableOperatorWriteNode: "https://github.com/target += value" KeywordHashNode: "[**{}]" LocalVariableOperatorAndWriteNode: target &&= value LocalVariableOperatorOrWriteNode: target ||= value OrNode: left or right RequiredDestructuredParameterNode: def foo((bar, baz)); end SourceFileNode: __FILE__ SourceLineNode: __LINE__ SourceEncodingNode: __ENCODING__ Notes: Entries associated with a YARP Node class indicate a formatting failure due to #format method not being implemented for given class; so in these cases the fix boils down to implementing format. For these entries the sample code that's given in the entry is the sample code from the YARP definition (config.yml), with one exception: the sample code for KeywordHashNode is 'foo(a: b)', but for that expression the formatting code preempts winding down to the KeywordHashNode instance, so the lack of KeywordHashNode#format is not triggered. The expression given for KeywordHashNode does indeed trigger KeywordHashNode#format. (Ironically, 'foo(a: b)' still had a formatting issue, but for a different reason.) The aforementioned class tagged entries and the ones where "formatting failure" is indicated raise an exception with SyntaxTree::Formatter.format; the other cases do return but with a bogus result. The hash related issues (ones where the word 'hash' occurs in the label, entries 2. to 4.) are shadowed by the first one (constant misnomer). Without fixing the name these entries will also end up with an exception. When the constant name is fixed, the indicated issue will be present. Tested with YARP 0eb5f7c3..">
Skip to content

Formatting fixes for YARP #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: yarp
Choose a base branch
from
Open

Formatting fixes for YARP #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading