Skip to content

Handle nil symbol in BasicVisitor#visit #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vinistock
Copy link
Contributor

In some scenarios, node may actually be the symbol nil. We weren't handling that and the visits would fail with undefined method accept for nil:Symbol.

@kddnewton
Copy link
Member

Thanks @vinistock - I solved this a different way by not returning [:nil] from child nodes instead to keep the interface consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants