Skip to content

AppContainer binding: provide both a functor-based and a functor-less version #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 11, 2019

  • The functor-based version should be easier to use for beginners as it gives you a normal ReasonReact component (module). But it is not zero-cost.
  • The non-functor-based version is zero-cost, but you need to do React.createElement(...) yourself. It allows advanced use cases such as (re)creating your AppContainer based e.g. on permission changes.

@MoOx
Copy link
Member

MoOx commented Sep 17, 2019

This looks like a breaking change too right?

@cknitt
Copy link
Member Author

cknitt commented Sep 17, 2019

Yes. We have only released an alpha so far, so I think that's alright.

The README is very outdated in any case, I will update it in a separate PR.

@MoOx MoOx merged commit f168502 into master Sep 18, 2019
@MoOx MoOx deleted the app-container branch September 18, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants