Support react-navigation 4.0.x (breaking change). #3
Conversation
|
Should we split into several bindings (packages/repo?) Would make sense even if "annoying" to handle? |
|
For the npm package, having version numbers that match the react-navigation version should be sufficient. In the repo, we could keep a |
|
I may not expressed myself correctly. I was more thinking about react-navigation-drawer, -stack & -tabs |
|
Ah, right, sorry. I think it's not worth the effort to have separate repos/npm packages for those, that would only complicate things further both for users and for us. |
|
I agree but people might looks for a given things & not look for it. |
|
Yes, that's a good idea! I'll do this in a follow-up PR. |
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "peerDependencies": { | ||
| "react-navigation": "^3.11.0" | ||
| }, |
There was a problem hiding this comment.
My idea of placing peered next to the version is to ensure we follow our versioning "rule" for the binding. Any thoughts about keeping peerDep around here?
|
@MoOx Regarding renaming: I forgot that we already have the namespace Or I would need to "namespace everything manually" instead of via |
|
Oh yeah. I guess documentation should be ok. |
I assume this will also break the example. After this + all the repo/package renaming is through, we should get the example to work again.