feat(Compute): string enums with constants for library Ga (GoogleCloudPlatform#1576)

Author: rsamborski

compute/cloud-client/instances/composer.json

@@ -1,6 +1,6 @@
 {
     "require": {
-        "google/cloud-compute": "^0.5.0",
-        "google/cloud-storage": "^1.23"
+        "google/cloud-compute": "^1.0.0",
+        "google/cloud-storage": "^1.26"
     }
 }

compute/cloud-client/instances/src/create_firewall_rule.php

@@ -27,10 +27,15 @@
 use Google\Cloud\Compute\V1\FirewallsClient;
 use Google\Cloud\Compute\V1\Allowed;
 use Google\Cloud\Compute\V1\Firewall;
-use Google\Cloud\Compute\V1\Firewall\Direction;
 
 /**
- * Creates a simple firewall rule allowing for incoming HTTP and HTTPS access from the entire Internet.
+ * To correctly handle string enums in Cloud Compute library
+ * use constants defined in the Enums subfolder.
+ */
+use Google\Cloud\Compute\V1\Enums\Firewall\Direction;
+
+/**
+ * Creates a simple firewall rule allowing incoming HTTP and HTTPS access from the entire internet.
  *
  * Example:
  * ```
@@ -56,7 +61,7 @@ function create_firewall_rule(string $projectId, string $firewallRuleName, strin
       ->setPorts(['80', '443']);
     $firewallResource = (new Firewall())
       ->setName($firewallRuleName)
-      ->setDirection(Direction::name(Direction::INGRESS))
+      ->setDirection(Direction::INGRESS)
       ->setAllowed([$allowedPorts])
       ->setSourceRanges(['0.0.0.0/0'])
       ->setTargetTags(['web'])

compute/cloud-client/instances/src/create_instance.php

@@ -29,10 +29,15 @@
 use Google\Cloud\Compute\V1\AttachedDiskInitializeParams;
 use Google\Cloud\Compute\V1\Instance;
 use Google\Cloud\Compute\V1\NetworkInterface;
-use Google\Cloud\Compute\V1\Operation;
 
 /**
- * Create an instance in the specified project and zone.
+ * To correctly handle string enums in Cloud Compute library
+ * use constants defined in the Enums subfolder.
+ */
+use Google\Cloud\Compute\V1\Enums\AttachedDisk\Type;
+
+/**
+ * Creates an instance in the specified project and zone.
  * Example:
  * ```
  * create_instance($projectId, $zone, $instanceName);
@@ -65,6 +70,7 @@ function create_instance(
     $disk = (new AttachedDisk())
         ->setBoot(true)
         ->setAutoDelete(true)
+        ->setType(Type::PERSISTENT)
         ->setInitializeParams($diskInitializeParams);
 
     // Use the network interface provided in the $networkName argument.