refactor: packument fetch logic

Currently we use `another-npm-registry-client` for fetching packuments. This is a fork of a deprecated library. This change instead uses the currently maintained library for fetching packuments that is maintained by npm Just to modernize the dependencies a bit.

Author: ComradeVanti

src/index.ts

@@ -1,6 +1,5 @@
 #!/usr/bin/env node
 
-import RegClient from "another-npm-registry-client";
 import npmlog from "npmlog";
 import updateNotifier from "update-notifier";
 import pkg from "../package.json";
@@ -29,11 +28,7 @@ const debugLogToConsole: DebugLog = async function (message, context) {
   return log.verbose("", `${message}${contextMessage}`);
 };
 
-const registryClient = new RegClient({ log });
-const fetchPackument = getRegistryPackumentUsing(
-  registryClient,
-  debugLogToConsole
-);
+const fetchPackument = getRegistryPackumentUsing(debugLogToConsole);
 const searchRegistry = searchRegistryUsing(debugLogToConsole);
 const fetchAllPackuments = getAllRegistryPackumentsUsing(debugLogToConsole);
 const getAuthToken = getAuthTokenUsing(debugLogToConsole);

src/io/registry.ts

@@ -1,4 +1,3 @@
-import type RegClient from "another-npm-registry-client";
 import npmSearch from "libnpmsearch";
 import { loginCouch } from "npm-profile";
 import npmFetch from "npm-registry-fetch";
@@ -129,26 +128,19 @@ export type GetRegistryPackument = (
  * from a remote npm registry.
  */
 export function getRegistryPackumentUsing(
-  registryClient: RegClient.Instance,
   debugLog: DebugLog
 ): GetRegistryPackument {
-  return (registry, name) => {
+  return async (registry, name) => {
     const url = `${registry.url}/${name}`;
-    return new Promise((resolve, reject) => {
-      return registryClient.get(
-        url,
-        { auth: registry.auth || undefined },
-        (error, packument) => {
-          if (error !== null) {
-            assertIsHttpError(error);
-            if (error.statusCode === 404) resolve(null);
-            else reject(error);
-          } else resolve(packument);
-        }
-      );
-    }).catch(async (error) => {
+    try {
+      const json = await npmFetch.json(url);
+      // TODO: Validate object
+      return json as UnityPackument;
+    } catch (error) {
+      assertIsHttpError(error);
+      if (error.statusCode === 404) return null;
       await debugLog("Fetching a packument failed.", error);
       throw makeRegistryInteractionError(error, registry.url);
-    });
+    }
   };
 }

test/integration/app/add-dependencies.test.ts

@@ -1,4 +1,3 @@
-import RegClient from "another-npm-registry-client";
 import nock from "nock";
 import {
   addDependenciesUsing,
@@ -81,10 +80,7 @@ describe("add dependencies", () => {
   const someProjectDir = "/users/some-user/projects/SomeProject";
 
   function makeDependencies() {
-    const fetchPackument = getRegistryPackumentUsing(
-      new RegClient(),
-      noopLogger
-    );
+    const fetchPackument = getRegistryPackumentUsing(noopLogger);
 
     const log = makeMockLogger();
 

test/integration/app/resolve-dependencies.test.ts

@@ -1,4 +1,3 @@
-import RegClient from "another-npm-registry-client";
 import nock from "nock";
 import { resolveDependenciesUsing } from "../../../src/app/resolve-dependencies";
 import { PackumentNotFoundError } from "../../../src/domain/common-errors";
@@ -32,11 +31,10 @@ describe("dependency resolving", () => {
   const someVersion = SemanticVersion.parse("1.0.0");
   const otherVersion = SemanticVersion.parse("2.0.0");
 
-  const registryClient = new RegClient();
   const resolveDependencies = partialApply(
     resolveDependenciesUsing,
     fetchCheckUrlExists,
-    getRegistryPackumentUsing(registryClient, noopLogger)
+    getRegistryPackumentUsing(noopLogger)
   );
 
   afterEach(() => {