Skip to content

TASK: Add easy docker compose setup to get up and running quickly #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023

Conversation

JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented May 1, 2023

No description provided.

@JamesAlias JamesAlias self-assigned this May 1, 2023
@JamesAlias JamesAlias force-pushed the task-easy-docker-setup branch from 0811c65 to e658e3e Compare May 1, 2023 11:07
@lorenzulrich
Copy link

TODO:

  • also add ddev setup?

I'd be in favour of having a ddev setup, yes. ddev is very easy to work with, widely supported and with good support. We're using ddev for all our development.

@JamesAlias JamesAlias force-pushed the task-easy-docker-setup branch from e658e3e to 79b0a80 Compare May 1, 2023 11:44
@JamesAlias JamesAlias force-pushed the task-easy-docker-setup branch from 79b0a80 to e0f4d1f Compare May 1, 2023 11:50
@JamesAlias
Copy link
Contributor Author

TODO:

  • also add ddev setup?

I'd be in favour of having a ddev setup, yes. ddev is very easy to work with, widely supported and with good support. We're using ddev for all our development.

Feel free to add it in a new PR 🙂
I want to enable people as fast as possible and docker compose should be a reasonable alternative for everyone.

I know @mficzel uses ddev as well so get in touch if you need help or discussion.

@JamesAlias JamesAlias marked this pull request as ready for review May 1, 2023 11:58
@JamesAlias JamesAlias requested review from lorenzulrich and mficzel and removed request for lorenzulrich May 1, 2023 11:58
@ClaraRuna
Copy link

ClaraRuna commented May 3, 2023

DAU proof! Works great :)

@JamesAlias JamesAlias merged commit 64dc3ef into 8.3 May 3, 2023
@JamesAlias JamesAlias deleted the task-easy-docker-setup branch May 3, 2023 10:30
@kdambekalns
Copy link
Member

kdambekalns commented May 10, 2023

@Kleisli
Copy link

Kleisli commented May 10, 2023

I'd be in favour of having a ddev setup, yes. ddev is very easy to work with, widely supported and with good support. We're using ddev for all our development.

ddev is definitely much easier than docker, I always ask myself who is "recommending" docker setup on docs.neos.io

but anyway, I have this work-in-progress Repo to setup Neos with a Site package on ddev, I'll probably add Carbon.Pipeline as a dependency for the frontend building..
https://github.com/Kleisli/neos-quickstart

@JamesAlias
Copy link
Contributor Author

JamesAlias commented May 15, 2023

As this is merged, it is vital to adjust https://docs.neos.io/guide/installation-development-setup/docker-and-docker-compose-setup @kdambekalns

I talked with @tobiasgruber about it and we agreed to let this part of the docs untouched as it felt like the documentation to get startet with setting up a Neos Base Distribution environment.

This setup is scoped to the Neos Development Distribution and aimed at contributers.

The "entrypoint" to the "Getting Started" docs are at https://docs.neos.io/guide/installation-development-setup (see "Contributing" Hint). And the docs for the new dev setup are here: https://docs.neos.io/guide/contributing-to-neos/neos-core#docker-setup

@kdambekalns
Copy link
Member

ddev is definitely much easier than docker

Very much depends… I have had to work with ddev setups that didn't even start the way it was supposed to work. With a working docker-compose.yaml in place "plain Docker" can be as easy as docker compose up, too. 😎

@JamesAlias
Copy link
Contributor Author

I will link docs urls on PRs in the future 🙂

@kdambekalns
Copy link
Member

This setup is scoped to the Neos Development Distribution and aimed at contributers.

Ah, I see. Ok, I guess that is useful. Not sure the distinction is clear enough, but that's not your fault by any means. Could even just be me. 🤷‍♂️😇

@JamesAlias
Copy link
Contributor Author

@Kleisli I agree with @kdambekalns.

There is nothing stopping you from adding a ddev setup and opening up a PR 🙂
It's mentioned in the docs as well: https://docs.neos.io/guide/installation-development-setup/ddev-local-beach

@Kleisli
Copy link

Kleisli commented May 15, 2023

With a working docker-compose.yaml in place "plain Docker" can be as easy as docker compose up, too. sunglasses

I tend to agree on that, but the problem is how to get there.. ;-)

Having a docker-compose.yaml in the distribution will definitely make it easier, but I remember having a hard time defining and linking all the containers from scratch years ago, and with ddev I had to configure much less. And I can run multiple projects at the same time on my machine. :-D

While it makes it a bit more complicated for newbies to decide, it's always good to have options. :) I'll try to check what it needs to add a default ddev config to the distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants