Skip to content

Commit 9f74e83

Browse files
davidsgroganjgraham
davidsgrogan
authored and
jgraham
committed
Bug 1528828 [wpt PR 15449] - [css-tables] Add some subpixel collapsed border tests, a=testonly
Automatic update from web-platform-tests [css-tables] Add some subpixel collapsed border tests This CL contains tests only, no behavior change. Chrome passes only 001, no matter the device pixels. Safari-lodpi and Firefox-lodpi pass only 001 and 002. EdgeHTML 18.17763-lodpi, Firefox-hidpi, and Safari-hidpi pass 001, 002, and 003. From a plain reading of the tables spec the 003 test is correct. But given its rampant failure (only EdgeHTML passes when 1x device pixel per CSS pixel), it'd be reasonable to codify the current empirical behavior somewhere, if it's not already in a place that I missed. Chrome probably passes 001 but fails 002 because of LayoutUnit's 1/64 pixel precision but that's not confirmed. Note that these tests will become invalid if the proposal in w3c/csswg-drafts#606 is adopted. Bug: 377847 Change-Id: Ifc9e8f9f878f7462cb949670350eadb17c7c2940 Reviewed-on: https://chromium-review.googlesource.com/c/1477334 Reviewed-by: Morten Stenshorne Reviewed-by: David Grogan Commit-Queue: David Grogan Cr-Commit-Position: refs/heads/master@{#633538} -- wpt-commits: 41a8506f54e688d655e662f59584dcbf777990f2 wpt-pr: 15449
1 parent 5ad44c3 commit 9f74e83

File tree

5 files changed

+134
-0
lines changed

5 files changed

+134
-0
lines changed

‎testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-001.html

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
>
2+
<link rel="author" title="David Grogan" href="mailto:[email protected]">
3+
<link rel="help" href="https://www.w3.org/TR/CSS22/tables.html#collapsing-borders">
4+
<link rel="help" href="https://drafts.csswg.org/css-tables-3/#border-conflict-resolution-algorithm">
5+
<link rel="help" href="https://github.com/w3c/csswg-drafts/issues/606">
6+
<link rel="match" href="subpixel-collapsed-borders-ref.html">
7+
<meta name="flags" content="" />
8+
<meta name="assert" content="When collapsed border tables have border widths larger than cells', the table border wins." />
9+
10+
<style>
11+
table {
12+
border: 5px solid green;
13+
border-collapse: collapse;
14+
}
15+
16+
td {
17+
width: 50px;
18+
height: 50px;
19+
border: 4.95px solid red;
20+
}
21+
style>
22+
23+
<p>There should be a square with a green border, not a red border.
24+
p>
25+
26+
<table>
27+
<tr>
28+
<td>td>
29+
tr>
30+
table>

‎testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-002.html

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
>
2+
<link rel="author" title="David Grogan" href="mailto:[email protected]">
3+
<link rel="help" href="https://www.w3.org/TR/CSS22/tables.html#collapsing-borders">
4+
<link rel="help" href="https://drafts.csswg.org/css-tables-3/#border-conflict-resolution-algorithm">
5+
<link rel="help" href="https://github.com/w3c/csswg-drafts/issues/606">
6+
<link rel="match" href="subpixel-collapsed-borders-ref.html">
7+
<meta name="flags" content="" />
8+
<meta name="assert" content="When collapsed border tables have border widths larger than cells', the table border wins even when the cell border is merely 0.01 pixels narrower" />
9+
10+
<style>
11+
table {
12+
border: 5px solid green;
13+
border-collapse: collapse;
14+
}
15+
16+
td {
17+
width: 50px;
18+
height: 50px;
19+
border: 4.99px solid red;
20+
}
21+
style>
22+
23+
<p>There should be a square with a green border, not a red border.
24+
p>
25+
26+
<table>
27+
<tr>
28+
<td>td>
29+
tr>
30+
table>

‎testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-003-ref.html

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
>
2+
<style>
3+
table {
4+
border: 5.95px solid green;
5+
border-collapse: collapse;
6+
}
7+
8+
td {
9+
width: 50px;
10+
height: 50px;
11+
border: 1px solid red;
12+
}
13+
style>
14+
15+
<p>There should be a square with a green border, not a red border.
16+
p>
17+
18+
<table>
19+
<tr>
20+
<td>td>
21+
tr>
22+
table>

‎testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-003.html

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
>
2+
<link rel="author" title="David Grogan" href="mailto:[email protected]">
3+
<link rel="help" href="https://www.w3.org/TR/CSS22/tables.html#collapsing-borders">
4+
<link rel="help" href="https://drafts.csswg.org/css-tables-3/#border-conflict-resolution-algorithm">
5+
<link rel="help" href="https://github.com/w3c/csswg-drafts/issues/606">
6+
<link rel="match" href="subpixel-collapsed-borders-003-ref.html">
7+
<meta name="flags" content="" />
8+
<meta name="assert" content="When collapsed border tables have border widths larger than cells', the table border wins even when the floored table border is the same size as the cell's." />
9+
10+
<style>
11+
table {
12+
border: 5.95px solid green;
13+
border-collapse: collapse;
14+
}
15+
16+
td {
17+
width: 50px;
18+
height: 50px;
19+
border: 5px solid red;
20+
}
21+
style>
22+
23+
<p>There should be a square with a green border, not a red border.
24+
p>
25+
26+
<table>
27+
<tr>
28+
<td>td>
29+
tr>
30+
table>

‎testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-ref.html

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
>
2+
<style>
3+
table {
4+
border: 5px solid green;
5+
border-collapse: collapse;
6+
}
7+
8+
td {
9+
width: 50px;
10+
height: 50px;
11+
border: 1px solid red;
12+
}
13+
style>
14+
15+
<p>There should be a square with a green border, not a red border.
16+
p>
17+
18+
<table>
19+
<tr>
20+
<td>td>
21+
tr>
22+
table>

0 commit comments

Comments
 (0)