Fix large file read issue in filesystem #480
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes modelcontextprotocol#478 Add functionality to handle reading large files in chunks. * Add a new function `readLargeFile` to read large files in chunks. * Update the `read_file` tool implementation to use `readLargeFile` for files larger than 1MB. * Improve error handling in the `read_file` tool to provide more detailed error messages. * Check file size before using `readLargeFile` to determine if the file exceeds the 1MB threshold. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/modelcontextprotocol/servers/issues/478?shareId=XXXX-XXXX-XXXX-XXXX).
dsp-ant
force-pushed
the
main
branch
29 times, most recently
from
ed3df93 to
da6fe62
Compare
dsp-ant
force-pushed
the
main
branch
27 times, most recently
from
c114833 to
4f3dc11
Compare
olaservo
added
enhancement
|
Looks like this older PR will be superseded by this one: #1027 Recommend closing this one once the other one is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
Add functionality to handle reading large files in chunks.
readLargeFileto read large files in chunks.read_filetool implementation to usereadLargeFilefor files larger than 1MB.read_filetool to provide more detailed error messages.readLargeFileto determine if the file exceeds the 1MB threshold.For more details, open the Copilot Workspace session.