Skip to content

Color Picker: fix incorrect ternary condition definition #251090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Conversation

aiday-mar
Copy link
Contributor

fixes #243746

@aiday-mar aiday-mar self-assigned this Jun 10, 2025
@aiday-mar aiday-mar marked this pull request as ready for review June 10, 2025 10:30
@aiday-mar aiday-mar enabled auto-merge (squash) June 10, 2025 10:30
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 10, 2025
Copy link

@DhruvTheDev1 DhruvTheDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix swaps the true and false part of the ternary to fix the opacity issue. So if there is alpha, it uses the alpha-including format, which keeps the opacity in the colour string.

@aiday-mar aiday-mar merged commit 9932324 into main Jun 10, 2025
8 checks passed
@aiday-mar aiday-mar deleted the slow-sparrow branch June 10, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker removes opacity when switching to hex
3 participants