Detect and fix cyclic runtime dependencies #251003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
added
important
|
|
|
#251024 for the frontMatterCodec/parsers cycle |
@connor4312 I still see this one ⬆️ |
DonJayamanne
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background historically we have never allowed to have cyclic runtime dependencies between our modules. The AMD loader would simply fail during load. Since the advent of ESM this has changed, browsers handle cycling dependencies graceful and things might work or not - it depends on the circumstances in which things get loaded (see #250990 for some fun). To prevent this madness, we have added a check for cyclic runtime dependencies (as part of the ESM work). Unfortunately, this check was broken and a couple of cyclic dependencies have slipped in. They should be cleaned-up ASAP
You can run
yarn watch-clientfrom this branch/PR to get this list of errors below. I have already done some simple cleanup but need help with the following:vs/workbench/contrib/chat/common/chatModel.js -> vs/workbench/contrib/chat/common/chatParserTypes.js -> vs/workbench/contrib/chat/common/chatModel.js@connor4312vs/editor/common/tokens/lineTokens.js -> vs/editor/common/tokens/tokenArray.js -> vs/editor/common/tokens/lineTokens.js@hedietvs/editor/common/core/text/positionToOffset.js -> vs/editor/common/core/edits/textEdit.js -> vs/editor/common/core/text/abstractText.js -> vs/editor/common/core/text/positionToOffset.js@hedietvs/editor/browser/gpu/raster/glyphRasterizer.js -> vs/editor/browser/gpu/viewGpuContext.js -> vs/editor/browser/gpu/atlas/textureAtlas.js -> vs/editor/browser/gpu/raster/glyphRasterizer.js@Tyriarvs/editor/common/model/tokens/treeSitter/treeSitterSyntaxTokenBackend.js -> vs/editor/common/model/tokens/treeSitter/treeSitterTree.js -> vs/editor/common/model/tokens/treeSitter/treeSitterSyntaxTokenBackend.js@hediet @alexr00vs/workbench/contrib/notebook/browser/notebookBrowser.js -> vs/workbench/contrib/notebook/browser/diff/notebookDiffEditor.js -> vs/workbench/contrib/notebook/browser/notebookEditorWidget.js -> vs/workbench/contrib/notebook/browser/notebookBrowser.js@rebornixvs/workbench/contrib/chat/browser/actions/chatActions.js -> vs/workbench/contrib/chat/browser/chatEditorInput.js -> vs/workbench/contrib/chat/browser/actions/chatActions.js@roblourensvs/workbench/contrib/scm/browser/scmHistory.js -> vs/workbench/contrib/scm/browser/util.js -> vs/workbench/contrib/scm/browser/scmHistory.js@lszomoruvs/workbench/contrib/chat/browser/chatContentParts/chatAttachmentsContentPart.js -> vs/workbench/contrib/chat/browser/chatAttachmentWidgets.js -> vs/workbench/contrib/chat/browser/chatContentParts/chatAttachmentsContentPart.js@jriekenvs/workbench/contrib/chat/browser/chatAttachmentResolve.js -> vs/workbench/contrib/chat/browser/chatPasteProviders.js -> vs/workbench/contrib/chat/browser/contrib/chatDynamicVariables.js -> vs/workbench/contrib/chat/browser/chatWidget.js -> vs/workbench/contrib/chat/browser/chatAccessibilityProvider.js -> vs/workbench/contrib/chat/browser/actions/chatToolActions.js -> vs/workbench/contrib/chat/browser/actions/chatToolPicker.js -> vs/workbench/contrib/mcp/browser/mcpCommands.js -> vs/workbench/contrib/mcp/browser/mcpResourceQuickAccess.js -> vs/workbench/contrib/chat/browser/chatAttachmentResolve.js@connor4312vs/workbench/contrib/extensions/browser/extensionsViewer.js -> vs/workbench/contrib/extensions/browser/extensionsViews.js -> vs/workbench/contrib/extensions/browser/extensionsViewer.js@sandy081workbench/contrib/chat/common/promptSyntax/codecs/base/frontMatterCodec/parsers/frontMatterValue.js -> workbench/contrib/chat/common/promptSyntax/codecs/base/frontMatterCodec/parsers/frontMatterArray.js -> workbench/contrib/chat/common/promptSyntax/codecs/base/frontMatterCodec/parsers/frontMatterValue.js@aeschli