Skip to content

Fix html derivative grammar consuming php code, fixes #237262 #245076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

KapitanOczywisty
Copy link
Contributor

@KapitanOczywisty KapitanOczywisty commented Mar 30, 2025

@alexr00 alexr00 enabled auto-merge (squash) April 2, 2025 12:46
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thank you for the fix!

@alexr00 alexr00 added this to the April 2025 milestone Apr 2, 2025
@alexr00 alexr00 merged commit 4064f17 into microsoft:main Apr 2, 2025
7 checks passed
@Guillerming
Copy link

Guillerming commented May 9, 2025

Hi @alexr00 I am experiencing syntax highlighting errors on my php documents after updating to version 1.100 and I presume it's related to this PR:

image.png

Steps to reproduce:

Add this snippet on a blank file

 new Component(
  function() { ?>
    

Failed to syntax highlight this

} );

@alexr00
Copy link
Member

alexr00 commented May 9, 2025

Thanks @Guillerming, I tried reverting this PR, but still get the same issue. I think it's a bug in the php grammar. I've opened an issue here: KapitanOczywisty/language-php#32

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php highlighting improvment
4 participants