Skip to content

Moving away from execCommand for pasting #239233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 4, 2025
Merged

Moving away from execCommand for pasting #239233

merged 19 commits into from
Apr 4, 2025

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Jan 30, 2025 •
edited
Loading

No description provided.

@aiday-mar aiday-mar self-assigned this Jan 30, 2025
@aiday-mar aiday-mar changed the title Investigating the clipboard API for browser and electron, execCommand investigating the clipboard API for browser and electron, execCommand Jan 31, 2025
@aiday-mar aiday-mar closed this Feb 6, 2025
@aiday-mar aiday-mar reopened this Feb 6, 2025
@aiday-mar aiday-mar changed the title investigating the clipboard API for browser and electron, execCommand Moving away from execCommand for pasting Feb 6, 2025
@aiday-mar aiday-mar requested a review from deepak1556 April 4, 2025 11:27
@aiday-mar aiday-mar marked this pull request as ready for review April 4, 2025 11:27
@aiday-mar aiday-mar enabled auto-merge (squash) April 4, 2025 11:27
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 4, 2025
deepak1556
deepak1556 reviewed Apr 4, 2025
View reviewed changes
@aiday-mar aiday-mar merged commit 8aead9b into main Apr 4, 2025
8 checks passed
@aiday-mar aiday-mar deleted the beneficial-xerinae branch April 4, 2025 12:44
bpasero
bpasero reviewed Apr 4, 2025
View reviewed changes
src/vs/platform/native/electron-main/nativeHostMainService.ts
@@ -751,6 +751,11 @@ export class NativeHostMainService extends Disposable implements INativeHostMain
return clipboard.readText(type);
}

async triggerPaste(windowId: number | undefined): Promise {
const window = this.windowById(windowId);
return window?.win?.webContents.paste() ?? Promise.resolve();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi, no need to use Promise.resolve()

lszomoru pushed a commit that referenced this pull request Apr 5, 2025
@aiday-mar @lszomoru
Moving away from execCommand for pasting (#239233)
b9a9ca6 
* adding code to invetsigate the clipboard

* adding more code

* adding change

* adding logs

* adding notes

* making deubgging easier

* adding code to fix paste

* adding code to allow await before trigger paste

* removing all logs

* removing log

* refactoring

* removing change

* adding fix after call

* polishing

* fixing merge conflict

* polishing
lszomoru added a commit that referenced this pull request Apr 6, 2025
@lszomoru @bpasero
@alexr00 @deepak1556 @benibenj @hediet @mdanish-kh @aiday-mar @aeschli
Engineering - background codesign for Windows stage (#245796)
e1ff10f 
* Add zx package

* Add stub task and script

* Add missing file

* Remove code

* Another try

* Fingers crossed

* Another try

* Add remaining steps

* Add back tasks

* Fix things

* Another try

* More fixes

* Use deemon

* Fixing things

* watcher - perf improvements for non-recursive watching (#245644)

* Feedback: before / after selectors not rendering correctly (#245645)

Fixes #244575

* Add highlights rule  for character escapes (#245647)

* ci: split gnu arm targets for cli stage (#245651)

* Fix inline edit acceptance on click (#245649)

fix clicking insertion does not accept

* Feedback: variables render differently in Insiders (#245650)

Fixes #244579

* !important different color (#245654)

Fixes #244632

* @Property css different color (#245656)

Fixes #244634

* > different color (#245658)

Fixes #244631

* notifications - adopt more `NotificationPriority.OPTIONAL` (#245664)

* Adds more inline completion tests

* Fixes CI

* feat: enable gpu channel async from the runtime (#241640)

* Update WinGet configuration file location & extension (#242241)

* Update WinGet configuration file location & extension

* Remove prerelease: true & add securityContext

* High CPU on large workspace with many TypeScript watched folders (fix #245366) (#245670)

* High CPU on large workspace with many TypeScript watched folders (fix #245366)

* reduce throttle delay

* Moving away from `execCommand` for pasting (#239233)

* adding code to invetsigate the clipboard

* adding more code

* adding change

* adding logs

* adding notes

* making deubgging easier

* adding code to fix paste

* adding code to allow await before trigger paste

* removing all logs

* removing log

* refactoring

* removing change

* adding fix after call

* polishing

* fixing merge conflict

* polishing

* Fixing property initializiation order (#245673)

fixing property initializiation order

* voice - fix some leaks (#245676)

* update css service (#245688)

* Engineering - bump deemon (#245634)

* Engineering - bump deemon

* Bump deemon again

* Always run the Codesign post-job

* Another fix

* Try signing in parallel

* Clean up signing script

Update task name

Tweak script

Some more cleanup

Some more cleanup

More cleanup

* Attempt to run signing in parallel

---------

Co-authored-by: Benjamin Pasero 
Co-authored-by: Alex Ross <[email protected]>
Co-authored-by: Robo 
Co-authored-by: Benjamin Christopher Simmonds <[email protected]>
Co-authored-by: Henning Dieterichs 
Co-authored-by: Muhammad Danish 
Co-authored-by: Aiday Marlen Kyzy 
Co-authored-by: Martin Aeschlimann
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero left review comments

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@aiday-mar @bpasero @deepak1556