Fix missing "Restart TS Server" command in Command Palette #223433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
cloneapp2024 |
connor4312
approved these changes
Jul 30, 2024
|
Thanks. Will be in the first 1.93 insiders build we release later this week |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210649
Problem
Some of the TypeScript extension command rely on certain context keys being updated.
Due to changes made in #201847 this logic was updated in
activeJsTsEditorTrackerto find active editors using tabs, so we can set the right context keys even if you've got the typescript files open in the diff view, and other scenarios.However, because the logic was being run on text editor events, it seems that the state of the
vscode.window.tabGroups.activeTabGroupwas not always correct, resulting in the wrong editor being chosen.As such, you might have a typescript editor open, but the commands wouldn't show up.
Fix
This PR adds a subscription to the
tabGroups.onDidChangeTabGroupsevent, so that when theActiveJsTsEditorTracker.update()method is run, theactiveTabGroupstate has already been updated correctly.