Show trust editor tab icon correctly for "window.density.editorTabHeight": "compact" (fix #196209)
#196212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight": "compact"` (fix microsoft#196209)
|
To me, this PR brings back the problem that the icon is a little high on the tab, however looking at other file icons, they also look too high, so perhaps this is just a general problem and the current fix is causing an issue. For that reason, approving this one. |
sbatten
approved these changes
Oct 23, 2023
aeschli
approved these changes
Oct 23, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
…ight": "compact"` (fix microsoft#196209) (microsoft#196212)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #196209
The
line-height: 37px !important;removed by this PR was introduced in #152904 by @sbatten, and predated the ability to set editor tab height.